-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(material/chips): add unit tests for custom aria-describedby #24657
base: main
Are you sure you want to change the base?
Conversation
e5cc439
to
313431e
Compare
This component will soon be deprecated in favor of the MDC one. Can you add this test there as well? |
@andrewseguin Unfortunately it seems I can't run the tests due to using a newer Macbook. I followed the steps here #23983 (comment) but no dice. |
@RobertAKARobin M1 should work to my knowledge. We should close the issue, unless you have more details. |
@devversion I'll follow up in that other issue. Once I've got |
313431e
to
f74a415
Compare
f74a415
to
8eb6706
Compare
@devversion Updated! The |
this._userAriaDescribedBy = userAriaDescribedBy; | ||
} | ||
|
||
private _userAriaDescribedBy: string; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the getter/setter needed here? Also I lack a little on context for this change I feel like. I thought we only needed the custom input when a component was a FormFieldControl
where we also added additional described by ids automatically, using .setDescribedByIds
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andrewseguin Can you explain a bit more about what changes you were looking for?
@devversion Yes, the getters/setters seem unnecessary. I was copying from the mat-chips code (which in turn was copied from mat-select, IIRC). Will wait to see what Andrew says though.
Continuation of #24292
See also #24644 for MatSelect