Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(material/autocomplete): outside click in Angular zone. #24817

Merged

Conversation

volvachev
Copy link
Contributor

Fixes a bug in Angular Material autocomplete when outside click doesn't trigger changeDetection.

Fixes #24811

Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a unit test for this?

src/material/autocomplete/autocomplete-trigger.ts Outdated Show resolved Hide resolved
@volvachev volvachev force-pushed the fix-autocomplete-trigger-outside branch from fbda157 to 91c59d6 Compare April 22, 2022 10:32
@volvachev
Copy link
Contributor Author

Can you add a unit test for this?

I've added test for it.

@volvachev volvachev requested a review from crisbeto April 22, 2022 10:33
@volvachev volvachev force-pushed the fix-autocomplete-trigger-outside branch from 91c59d6 to db3bf3d Compare April 22, 2022 11:25
@volvachev volvachev force-pushed the fix-autocomplete-trigger-outside branch from db3bf3d to 85bb169 Compare April 22, 2022 11:43
Fixes a bug in Angular Material `autocomplete` when outside click doesn't trigger `changeDetection`.

Fixes angular#24811
@volvachev volvachev force-pushed the fix-autocomplete-trigger-outside branch from 85bb169 to d112a68 Compare April 22, 2022 11:50
@volvachev volvachev requested a review from crisbeto April 22, 2022 12:07
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Apr 22, 2022
@andrewseguin andrewseguin self-assigned this Apr 22, 2022
@andrewseguin andrewseguin merged commit 4e5e286 into angular:master Apr 22, 2022
andrewseguin pushed a commit that referenced this pull request Apr 22, 2022
Fixes a bug in Angular Material `autocomplete` when outside click doesn't trigger `changeDetection`.

Fixes #24811

(cherry picked from commit 4e5e286)
crapStone pushed a commit to Calciumdibromid/CaBr2 that referenced this pull request May 1, 2022
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [@angular/cdk](https://github.com/angular/components) | dependencies | patch | [`13.3.4` -> `13.3.5`](https://renovatebot.com/diffs/npm/@angular%2fcdk/13.3.4/13.3.5) |
| [@angular/material](https://github.com/angular/components) | dependencies | patch | [`13.3.4` -> `13.3.5`](https://renovatebot.com/diffs/npm/@angular%2fmaterial/13.3.4/13.3.5) |

---

### Release Notes

<details>
<summary>angular/components</summary>

### [`v13.3.5`](https://github.com/angular/components/blob/HEAD/CHANGELOG.md#&#8203;1335-bread-bun-2022-04-27)

[Compare Source](angular/components@13.3.4...13.3.5)

##### cdk

| Commit | Type | Description |
| -- | -- | -- |
| [68d09ddecd](angular/components@68d09dd) | fix | **overlay:** animations interrupted on repeat insertions ([#&#8203;24815](angular/components#24815)) |

##### material

| Commit | Type | Description |
| -- | -- | -- |
| [86a1e8c7be](angular/components@86a1e8c) | fix | **autocomplete:** outside click in Angular zone. ([#&#8203;24817](angular/components#24817)) |

##### material-experimental

| Commit | Type | Description |
| -- | -- | -- |
| [b16a33dbb2](angular/components@b16a33d) | fix | **mdc-slider:** remove pointerdown passive eve… ([#&#8203;24766](angular/components#24766)) |
| [6603bd5ec6](angular/components@6603bd5) | fix | **mdc-snack-bar:** avoid querying the DOM on each change detection ([#&#8203;24770](angular/components#24770)) |

#### Special Thanks

Egor Volvachev, Jesse Beder, Kirill Cherkashin, Kristiyan Kostadinov, Paul Gschwendtner, Ruslan Lekhman, Sukka and Wagner Maciel

<!-- CHANGELOG SPLIT MARKER -->

</details>

---

### Configuration

📅 **Schedule**: At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

Co-authored-by: cabr2-bot <[email protected]>
Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1330
Reviewed-by: Epsilon_02 <[email protected]>
Co-authored-by: Calciumdibromid Bot <[email protected]>
Co-committed-by: Calciumdibromid Bot <[email protected]>
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
3 participants