Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(material/menu): add constructor overloads for non-deprecated signatures #24860

Merged
merged 1 commit into from
May 2, 2022

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented May 2, 2022

In #24116 I explored using constructor overload for deprecations, but I forgot to add an overload for the non-deprecated signatures.

Fixes #24740.

…atures

In angular#24116 I explored using constructor overload for deprecations, but I forgot to add an overload for the non-deprecated signatures.

Fixes angular#24740.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels May 2, 2022
@crisbeto crisbeto requested a review from andrewseguin May 2, 2022 07:34
@andrewseguin andrewseguin added the action: merge The PR is ready for merge by the caretaker label May 2, 2022
@andrewseguin andrewseguin self-assigned this May 2, 2022
@andrewseguin andrewseguin merged commit 08851de into angular:main May 2, 2022
andrewseguin pushed a commit that referenced this pull request May 2, 2022
…atures (#24860)

In #24116 I explored using constructor overload for deprecations, but I forgot to add an overload for the non-deprecated signatures.

Fixes #24740.

(cherry picked from commit 08851de)
crapStone pushed a commit to Calciumdibromid/CaBr2 that referenced this pull request May 13, 2022
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [@angular/cdk](https://github.com/angular/components) | dependencies | patch | [`13.3.5` -> `13.3.6`](https://renovatebot.com/diffs/npm/@angular%2fcdk/13.3.5/13.3.6) |
| [@angular/material](https://github.com/angular/components) | dependencies | patch | [`13.3.5` -> `13.3.6`](https://renovatebot.com/diffs/npm/@angular%2fmaterial/13.3.5/13.3.6) |

---

### Release Notes

<details>
<summary>angular/components</summary>

### [`v13.3.6`](https://github.com/angular/components/blob/HEAD/CHANGELOG.md#&#8203;1336-iridium-ire-2022-05-04)

[Compare Source](angular/components@13.3.5...13.3.6)

##### material

| Commit | Type | Description |
| -- | -- | -- |
| [6a0e6ba510](angular/components@6a0e6ba) | fix | **menu:** add constructor overloads for non-deprecated signatures ([#&#8203;24860](angular/components#24860)) |

##### material-experimental

| Commit | Type | Description |
| -- | -- | -- |
| [8ca629dc7e](angular/components@8ca629d) | fix | **mdc-snack-bar:** avoid multiple snack bars on the page if opened in quick succession ([#&#8203;24757](angular/components#24757)) |
| [d6f9db37b0](angular/components@d6f9db3) | fix | **mdc-table:** add inherit background to rows ([#&#8203;24867](angular/components#24867)) |

#### Special Thanks

Andrew Seguin, Daniil Dubrava, Jeremy Elbourn, Kristiyan Kostadinov and Paul Gschwendtner

<!-- CHANGELOG SPLIT MARKER -->

</details>

---

### Configuration

📅 **Schedule**: At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

Co-authored-by: cabr2-bot <[email protected]>
Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1342
Reviewed-by: Epsilon_02 <[email protected]>
Co-authored-by: Calciumdibromid Bot <[email protected]>
Co-committed-by: Calciumdibromid Bot <[email protected]>
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(menu): Only deprecated constructor overloads are in the declaration file
2 participants