feat(tooltip): reposition on scroll #2703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
Looking into why IE/FF is having issues... |
jelbourn
reviewed
Jan 24, 2017
|
|
||
|
|
||
| /** Time in ms to throttle the scrolling events by default. */ | ||
| export const DEFAULT_AUDIT_TIME = 20; |
There was a problem hiding this comment.
How about DEFAULT_SCROLL_THROTTLE?
src/lib/tooltip/tooltip.ts
Outdated
| ngOnInit() { | ||
| // When a scroll on the page occurs, update the position in case this tooltip needs | ||
| // to be repositioned. | ||
| this._scrollDispatcher.scrolled(SCROLL_THROTTLE_MS).subscribe(() => { |
There was a problem hiding this comment.
Need to unsubscribe on ngOnDestroy
andrewseguin
force-pushed
the
throttled-scroll
branch
from
c5de08b
to
ed7055e
Compare
mmalerba
approved these changes
Jan 31, 2017
andrewseguin
force-pushed
the
throttled-scroll
branch
2 times, most recently
from
21c776d
to
f8d8f20
Compare
andrewseguin
force-pushed
the
throttled-scroll
branch
from
f8d8f20
to
86a78cd
Compare
andrewseguin
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reposition uses a throttled scroll event from the scroll dispatcher. If the reposition causes the tooltip to be clipped by a scrollable container, then hide the tooltip.