Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ripple): make ripples conform with specs #2859

Merged
merged 6 commits into from
Feb 10, 2017
Merged

fix(ripple): make ripples conform with specs #2859

merged 6 commits into from
Feb 10, 2017

Commits on Feb 9, 2017

  1. fix(ripple): make ripples conform with specs 

    This makes the ripple service conform with the specifications and other Material reference implementations.

See https://material.io/guidelines/motion/material-motion.html#material-motion-how-does-material-move

This means the following:

 * Ripples now trigger on `mousedown`
 * Ripples now persists as long as the element is being hold.
 * No longer adds an unnecessary background ripple.
 * Removes the ugly `scale(0.00001)` for ripple animations

Not only visually the ripple has been changed. The whole renderer has been rewritten and now has a very simple API, that can be easily used by developers.

References angular#1434
    @devversion
    devversion committed Feb 9, 2017
    Configuration menu
    Copy the full SHA
    59e8553 View commit details
    Browse the repository at this point in the history

  2. Fix linting and IE11 unsupported error

    @devversion
    devversion committed Feb 9, 2017
    Configuration menu
    Copy the full SHA
    8566532 View commit details
    Browse the repository at this point in the history

  3. Ensure style recalculation

    @devversion
    devversion committed Feb 9, 2017
    Configuration menu
    Copy the full SHA
    77c46bb View commit details
    Browse the repository at this point in the history

  4. Address comments

    @devversion
    devversion committed Feb 9, 2017
    Configuration menu
    Copy the full SHA
    af169a0 View commit details
    Browse the repository at this point in the history

  5. Address feedback

    @devversion
    devversion committed Feb 9, 2017
    Configuration menu
    Copy the full SHA
    f972123 View commit details
    Browse the repository at this point in the history

  6. Document that fade-out duration can't be modified through the speedFa… 

    …ctor
    @devversion
    devversion committed Feb 9, 2017
    Configuration menu
    Copy the full SHA
    48bccb5 View commit details
    Browse the repository at this point in the history