fix(cdk/drag-drop): use native popover to avoid stacking issues with preview #28945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lass Moves the logic for creating and managing the preview into a separate class to make it a bit easier to manage. This new class is internal only.
…preview Wraps the preview element in a native popover which allows it to always be rendered on top of everything and to avoid issues when the parent element has a `transform`. Fixes angular#28889.
crisbeto
added
target: patch
zarend
approved these changes
Apr 24, 2024
1 task
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Apr 29, 2024
After angular#28945 the preview is inserted into a `popover` element which has a user agent styling of `color: canvastext`. These changes reset it to `inherit` to match the old behavior. Fixes angular#28974.
Merged
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Apr 29, 2024
After angular#28945 the preview is inserted into a `popover` element which has a user agent styling of `color: canvastext`. These changes reset it to `inherit` to match the old behavior. Fixes angular#28974.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Apr 30, 2024
After angular#28945 the preview is inserted into a `popover` element which has a user agent styling of `color: canvastext`. These changes reset it to `inherit` to match the old behavior. Fixes angular#28974.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wraps the preview element in a native popover which allows it to always be rendered on top of everything and to avoid issues when the parent element has a
transform.Fixes #28889.