Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: move some CDK tests to zoneless #29103

Merged
merged 3 commits into from
May 29, 2024
Merged

test: move some CDK tests to zoneless #29103

merged 3 commits into from
May 29, 2024

Conversation

mmalerba
Copy link
Contributor

No description provided.

@mmalerba mmalerba added the target: patch This PR is targeted for the next patch release label May 22, 2024
atscott
atscott requested changes May 23, 2024
View reviewed changes
src/cdk/overlay/overlay.spec.ts Show resolved Hide resolved
src/cdk/overlay/overlay.spec.ts Show resolved Hide resolved
src/cdk/scrolling/virtual-scroll-viewport.spec.ts Outdated Show resolved Hide resolved
src/cdk/scrolling/virtual-scroll-viewport.spec.ts Show resolved Hide resolved
src/cdk/scrolling/virtual-scroll-viewport.spec.ts Outdated Show resolved Hide resolved
src/cdk/scrolling/virtual-scroll-viewport.spec.ts Show resolved Hide resolved
@mmalerba mmalerba force-pushed the zone-tests-2 branch 2 times, most recently from d4bc7be to 0eb9de8 Compare May 24, 2024 00:37
@mmalerba mmalerba marked this pull request as ready for review May 24, 2024 00:37
@mmalerba mmalerba force-pushed the zone-tests-2 branch 2 times, most recently from 1d63fa6 to 78efec9 Compare May 24, 2024 04:14
@mmalerba mmalerba requested a review from atscott May 24, 2024 04:15
atscott
atscott requested changes May 28, 2024
View reviewed changes
src/cdk/overlay/overlay.spec.ts Outdated Show resolved Hide resolved
src/cdk/overlay/overlay.spec.ts Show resolved Hide resolved
src/cdk/scrolling/scrollable.spec.ts Outdated Show resolved Hide resolved
src/cdk/scrolling/scrollable.spec.ts Outdated Show resolved Hide resolved
src/cdk/scrolling/virtual-scroll-viewport.spec.ts Outdated Show resolved Hide resolved
src/cdk/scrolling/virtual-scroll-viewport.spec.ts Outdated Show resolved Hide resolved
@mmalerba mmalerba marked this pull request as draft May 29, 2024 03:21
@mmalerba mmalerba marked this pull request as ready for review May 29, 2024 16:31
@mmalerba
Copy link
Contributor Author

This is ready for another round of review

atscott
atscott approved these changes May 29, 2024
View reviewed changes
Copy link
Contributor

@atscott atscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@angular-robot angular-robot bot requested a review from atscott May 29, 2024 16:40
@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label May 29, 2024
@mmalerba mmalerba removed the request for review from atscott May 29, 2024 16:59
@mmalerba mmalerba merged commit 205c0a4 into angular:main May 29, 2024
24 checks passed
mmalerba added a commit that referenced this pull request May 29, 2024
@mmalerba
test: move some CDK tests to zoneless (#29103)
c1f3aa9 
* test: move some CDK tests to zoneless

* test: Fix flakiness in virtual scroll tests

* test: remove overzealous markForCheck calls

(cherry picked from commit 205c0a4)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@atscott atscott atscott approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmalerba @atscott