Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(material/button-toggle): skip disabled buttons during keyboard navigation #29308

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

crisbeto
Copy link
Member

Fixes that the button toggle was selecting disabled buttons and attempting to focus them when using the arrow keys.

Fixes #29304.

…vigation

Fixes that the button toggle was selecting disabled buttons and attempting to focus them when using the arrow keys.

Fixes angular#29304.
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Jun 24, 2024
@crisbeto crisbeto requested a review from a team as a code owner June 24, 2024 07:08
@crisbeto crisbeto requested review from mmalerba and andrewseguin and removed request for a team June 24, 2024 07:08
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Jun 24, 2024
@crisbeto crisbeto merged commit d9181b5 into angular:main Jun 24, 2024
22 of 25 checks passed
crisbeto added a commit that referenced this pull request Jun 24, 2024
…vigation (#29308)

Fixes that the button toggle was selecting disabled buttons and attempting to focus them when using the arrow keys.

Fixes #29304.

(cherry picked from commit d9181b5)
DBowen33 pushed a commit to DBowen33/components that referenced this pull request Jul 3, 2024
…vigation (angular#29308)

Fixes that the button toggle was selecting disabled buttons and attempting to focus them when using the arrow keys.

Fixes angular#29304.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(mat-button-toggle): Disabled buttons are not ignored in radio pattern interaction for single select
2 participants