Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(material/sidenav): disable focus trap while closed #29548

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Aug 7, 2024

Completely disables the sidenav's focus trap while it's closed so users can't tab to the anchors.

Fixes #29545.

Completely disables the sidenav's focus trap while it's closed so users can't tab to the anchors.

Fixes angular#29545.
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Aug 7, 2024
@crisbeto crisbeto requested a review from a team as a code owner August 7, 2024 09:30
@crisbeto crisbeto requested review from amysorto, mmalerba, andrewseguin and wagnermaciel and removed request for a team August 7, 2024 09:30
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Aug 7, 2024
@crisbeto crisbeto merged commit 626164b into angular:main Aug 7, 2024
23 of 25 checks passed
crisbeto added a commit that referenced this pull request Aug 7, 2024
Completely disables the sidenav's focus trap while it's closed so users can't tab to the anchors.

Fixes #29545.

(cherry picked from commit 626164b)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(sidenav/drawer/focustrap): over/push mode do not remove tabindex="0" when drawer closed
2 participants