fix(material/tabs): allow for tablist aria-label and aria-labelledby to be set #29562
Conversation
…to be set According to the [W3C reference implementation](https://www.w3.org/WAI/ARIA/apg/patterns/tabs/), the inner `tablist` can be labelled using `aria-label` or `aria-labelledby`. These changes add an input to allow them to be set. Fixes angular#29486.
crisbeto
requested review from
amysorto and
andrewseguin
and removed request for
a team
| @@ -242,6 +242,12 @@ export class MatTabGroup implements AfterContentInit, AfterContentChecked, OnDes | |||
|
|
|||
| private _backgroundColor: ThemePalette; | |||
|
|
|||
| /** Aria label of the inner `tablist` of the group. */ | |||
| @Input('aria-label') ariaLabel: string; | |||
There was a problem hiding this comment.
I'm a bit on the fence if this should be aria-label or something like tabListAriaLabel. I went with the shorter one, because the mat-tab-group doesn't have a role.
There was a problem hiding this comment.
It also seems some of out other components (like autocomplete) follow the same too with just calling the input ariaLabel
| @@ -242,6 +242,12 @@ export class MatTabGroup implements AfterContentInit, AfterContentChecked, OnDes | |||
|
|
|||
| private _backgroundColor: ThemePalette; | |||
|
|
|||
| /** Aria label of the inner `tablist` of the group. */ | |||
| @Input('aria-label') ariaLabel: string; | |||
There was a problem hiding this comment.
It also seems some of out other components (like autocomplete) follow the same too with just calling the input ariaLabel
…to be set (#29562) According to the [W3C reference implementation](https://www.w3.org/WAI/ARIA/apg/patterns/tabs/), the inner `tablist` can be labelled using `aria-label` or `aria-labelledby`. These changes add an input to allow them to be set. Fixes #29486. (cherry picked from commit 1968cc4)
…to be set (#29562) According to the [W3C reference implementation](https://www.w3.org/WAI/ARIA/apg/patterns/tabs/), the inner `tablist` can be labelled using `aria-label` or `aria-labelledby`. These changes add an input to allow them to be set. Fixes #29486. (cherry picked from commit 1968cc4)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
According to the W3C reference implementation, the inner
tablistcan be labelled usingaria-labeloraria-labelledby. These changes add an input to allow them to be set.Fixes #29486.