fix(material/core): add missing system variables #29624
Conversation
andrewseguin
requested review from
crisbeto,
amysorto and
wagnermaciel
and removed request for
a team
| } | ||
| } | ||
|
|
||
| @mixin system-level-shape($theme, $overrides: (), $prefix: $_system-level-prefix) { | ||
| @mixin system-level-shape($theme: (), $overrides: (), $prefix: $_system-level-prefix) { |
There was a problem hiding this comment.
Why are we adding a default here? I'd be a bit concerned about apps depending doing @include mat.system-level-shape().
There was a problem hiding this comment.
I feel like requiring a theme config makes it seem like it does something here, but its ignored in the mixin since our themes dont actually allow this to be configured.
That said, Im not strongly opinionated about making this optional - we can leave it the way it is
There was a problem hiding this comment.
Ah I see, the theme only has an effect in the color and typography mixins. In that case it's fine by me.
| } | ||
| } | ||
|
|
||
| @mixin system-level-shape($theme, $overrides: (), $prefix: $_system-level-prefix) { | ||
| @mixin system-level-shape($theme: (), $overrides: (), $prefix: $_system-level-prefix) { |
There was a problem hiding this comment.
Ah I see, the theme only has an effect in the color and typography mixins. In that case it's fine by me.
andrewseguin
added
action: merge
andrewseguin
requested review from
amysorto
and removed request for
wagnermaciel and
amysorto
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
theme(color, typography, and density) and adds support for defaults and simplified arguments (this is an experimental private API, and still under design and implementation)