fix(material/core): stop manually instantiating MatRipple directive #29630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we had to manually instantiate `MatRipple` in order to maintain backwards compatibility, but it was problematic because it would break whenever we tried to use DI in `MatRipple` and it prevented us from switching to the `inject` function. Instantiating `MatRipple` is no longer necessary after angular#29622 so these changes switch to creating an internal `RippleRenderer` instead.
crisbeto
requested review from
amysorto,
andrewseguin and
devversion
and removed request for
a team
devversion
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we had to manually instantiate
MatRipplein order to maintain backwards compatibility, but it was problematic because it would break whenever we tried to use DI inMatRippleand it prevented us from switching to theinjectfunction.Instantiating
MatRippleis no longer necessary after #29622 so these changes switch to creating an internalRippleRendererinstead.