Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(multiple): ripples not showing up in some cases #29672

Merged
merged 1 commit into from
Sep 3, 2024
Merged

fix(multiple): ripples not showing up in some cases #29672

merged 1 commit into from
Sep 3, 2024

Conversation

crisbeto
Copy link
Member

Fixes the following issues that prevented the ripples from showing up:

  • We weren't passing an injector into the RippleRenderer created by the RippleLoader which meant that it was never injecting the structural styles.
  • The checkbox and tabs ripple selectors weren't specific enough which meant that they would be overridden in some cases. We were handling this in other components, but for some reason these two were skipped.

Fixes #29670.

@crisbeto
fix(multiple): ripples not showing up in some cases
827ae4b 
Fixes the following issues that prevented the ripples from showing up:
* We weren't passing an injector into the `RippleRenderer` created by the `RippleLoader` which meant that it was never injecting the structural styles.
* The checkbox and tabs ripple selectors weren't specific enough which meant that they would be overridden in some cases. We were handling this in other components, but for some reason these two were skipped.

Fixes angular#29670.
@crisbeto crisbeto added the target: major This PR is targeted for the next major release label Aug 30, 2024
@crisbeto crisbeto requested a review from a team as a code owner August 30, 2024 12:09
@crisbeto crisbeto requested review from amysorto and wagnermaciel and removed request for a team August 30, 2024 12:09
@crisbeto crisbeto mentioned this pull request Aug 30, 2024
Closed
@crisbeto crisbeto removed the request for review from amysorto September 3, 2024 16:05
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Sep 3, 2024
@crisbeto crisbeto merged commit b3a9062 into angular:main Sep 3, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wagnermaciel wagnermaciel wagnermaciel approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docs-bug(Button): Add to docs that buttons now need matRipple
2 participants
@crisbeto @wagnermaciel