Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(google-maps/map-advanced-marker): Add support for some mouse events #29741 #29747

Merged
merged 1 commit into from
Sep 18, 2024
Merged

feat(google-maps/map-advanced-marker): Add support for some mouse events #29741 #29747

merged 1 commit into from
Sep 18, 2024
+51 −1

Conversation

sidhanshamil
Copy link
Contributor

This PR adds support for the following mouse events to the map-advanced-marker component:

  • Double click (dblclick)
  • Mouse out (mouseout)
  • Mouse over (mouseover)
  • Mouse up (mouseup)
  • Right click (right-click)

These events were available in the deprecated map-marker and are now implemented to enable similar functionality in map-advanced-marker.

Testing:

  • Unit tests added for each event.

@sidhanshamil sidhanshamil requested a review from a team as a code owner September 17, 2024 10:50
@sidhanshamil sidhanshamil requested review from crisbeto and amysorto and removed request for a team September 17, 2024 10:50
@angular-robot angular-robot bot added the detected: feature PR contains a feature commit label Sep 17, 2024
@sidhanshamil sidhanshamil changed the title feat(google-maps/map-advanced-marker): Add support for some mouse events feat(google-maps/map-advanced-marker): Add support for some mouse events #29741 Sep 18, 2024
crisbeto
crisbeto approved these changes Sep 18, 2024
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto removed the request for review from amysorto September 18, 2024 06:48
@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release merge: fix commit message When the PR is merged, rewrites/fixups of the commit messages are needed labels Sep 18, 2024
@crisbeto
Copy link
Member

Can you run yarn bazel run //tools/public_api_guard:google-maps/google-maps.md_api.accept and push the changed file?

@crisbeto crisbeto merged commit 1bd976c into angular:main Sep 18, 2024
20 of 22 checks passed
@crisbeto crisbeto mentioned this pull request Sep 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crisbeto crisbeto crisbeto approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker detected: feature PR contains a feature commit merge: fix commit message When the PR is merged, rewrites/fixups of the commit messages are needed target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sidhanshamil @crisbeto