fix(snack-bar): improper button styling and improved handling of long text #2991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… text * Simplifies the snack bar styles, removing some redundancy. * Fixes the snack bar using the `md-button` styles directly. This causes it to break if another `md-button` isn't on the page in order to import the styles. These changes switch to styling the snack bar button independently since it barely shares any styles with `md-button` anyway. * Fixes a wrong selector that wasn't styling anything. * Adds better handling for long text strings inside snack bars. Fixes angular#2979.
googlebot
added
the
cla: yes
andrewseguin
approved these changes
Feb 8, 2017
andrewseguin
added
pr: lgtm
action: merge
|
The selector issue wasn't due to the |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
md-buttonstyles directly. This causes it to break if anothermd-buttonisn't on the page in order to import the styles. These changes switch to styling the snack bar button independently since it barely shares any styles withmd-buttonanyway.Fixes #2979.