-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(tab): use MD_RIPPLE_GLOBAL_OPTIONS in tab #3553
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,7 +9,7 @@ import { | |
import {MdInkBar} from '../ink-bar'; | ||
import {MdRipple} from '../../core/ripple/index'; | ||
import {ViewportRuler} from '../../core/overlay/position/viewport-ruler'; | ||
import {MD_DISABLE_RIPPLES} from '../../core/ripple/ripple'; | ||
import {MD_RIPPLE_GLOBAL_OPTIONS} from '../../core/ripple/ripple'; | ||
|
||
/** | ||
* Navigation component matching the styles of the tab group header. | ||
|
@@ -83,7 +83,7 @@ export class MdTabLink { | |
}) | ||
export class MdTabLinkRipple extends MdRipple { | ||
constructor(elementRef: ElementRef, ngZone: NgZone, ruler: ViewportRuler, | ||
@Optional() @Inject(MD_DISABLE_RIPPLES) forceDisableRipples: boolean) { | ||
@Optional() @Inject(MD_RIPPLE_GLOBAL_OPTIONS) forceDisableRipples: boolean) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can we rename that to Also sorry couldn't do anything about it, the PR from Andrew was merged before and I had no chance to rebase on top of it again :P There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Updated. Please take another look. Thanks |
||
super(elementRef, ngZone, ruler, forceDisableRipples); | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was just about to submit a PR for this :D. I think the parameter here has to be renamed as well.