Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(autocomplete): reposition panel on scroll #3745

Merged
merged 1 commit into from
Apr 21, 2017
Merged

fix(autocomplete): reposition panel on scroll #3745

merged 1 commit into from
Apr 21, 2017

Conversation

crisbeto
Copy link
Member

Repositions the autocomplete panel if the users scrolls while it is open.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 23, 2017
@jefersonestevo
Copy link
Contributor

jefersonestevo commented Mar 23, 2017 •
edited
Loading

@crisbeto is this going to fix #3722

@crisbeto
Copy link
Member Author

crisbeto commented Mar 23, 2017 •
edited
Loading

Probably not, but I think I have an idea on how to fix it. I'll take a better look tomorrow.

@googlebot googlebot added cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla and removed cla: yes PR author has agreed to Google's Contributor License Agreement labels Mar 27, 2017
@googlebot googlebot added cla: yes PR author has agreed to Google's Contributor License Agreement and removed cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla labels Mar 27, 2017
@armstrjare armstrjare mentioned this pull request Apr 13, 2017
Merged
kara
kara approved these changes Apr 20, 2017
View reviewed changes
Copy link
Contributor

@kara kara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one nit. Apply merge label when rebased and ready.

src/lib/autocomplete/autocomplete-trigger.ts Outdated
@@ -72,6 +73,10 @@ export class MdAutocompleteTrigger implements ControlValueAccessor, OnDestroy {
/** The subscription to positioning changes in the autocomplete panel. */
private _panelPositionSubscription: Subscription;

/** Subscription to global scroll events. */
private _scrolledSubscription: Subscription;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: _scrollSubscription

@kara kara assigned crisbeto and unassigned kara Apr 20, 2017
@crisbeto
fix(autocomplete): reposition panel on scroll
67104a7 
Repositions the autocomplete panel if the users scrolls while it is open.
@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker and removed pr: needs rebase labels Apr 20, 2017
@kara kara merged commit 81a6f8d into angular:master Apr 21, 2017
@filipows filipows mentioned this pull request May 24, 2017
Closed
@grizzm0 grizzm0 mentioned this pull request Jul 13, 2017
Closed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kara kara kara approved these changes

Assignees

@crisbeto crisbeto

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crisbeto @jefersonestevo @kara @googlebot