fix(ng-dev): improve spinner experience when executed in a CI environment #2426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ment Improve the spinner experience in a CI environment so that it does not show the same message repeatedly, but also continues to show output to prevent CI environments from treating the execution as inactive.
devversion
reviewed
Nov 7, 2024
|
|
||
| /** Whether execution is in a CI environment. */ | ||
| const IS_CI = process.env['CI']; |
There was a problem hiding this comment.
At this point in time we keep making the spinner more complicated. Should we consider just using a library here?
There was a problem hiding this comment.
This is still markedly less complicated than a library has, we can if you would like, but I do personally like the total control we have in this case. But if you feel strongly I am happy to look into options for us.
devversion
approved these changes
Nov 7, 2024
|
This PR was merged into the repository by commit 11967c8. The changes were merged into the following branches: main |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the spinner experience in a CI environment so that it does not show the same message repeatedly, but also continues to show output to prevent CI environments from treating the execution as inactive.