Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ng-dev): yarnpkg lockfile package cannot be bundled with ESM #615

Merged
merged 2 commits into from
Jun 15, 2022

Conversation

devversion
Copy link
Member

ESBuild bundles CommonJS packages, but some cannot be due to use of
CJS-only features. The yarn lockfile is one package that needs to be
kept external for it to leverage CJS features through NodeJS built-in
ESM -> CJS interop.

ESBuild bundles CommonJS packages, but some cannot be due to use of
CJS-only features. The yarn lockfile is one package that needs to be
kept external for it to leverage CJS features through NodeJS built-in
ESM -> CJS interop.
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devversion
Copy link
Member Author

Related issue: evanw/esbuild#1874

@devversion devversion closed this Jun 15, 2022
@devversion devversion reopened this Jun 15, 2022
@devversion devversion merged commit 5c2160c into angular:esm-migration Jun 15, 2022
@devversion devversion deleted the yarn-dirname branch June 15, 2022 22:14
@devversion devversion added the action: merge The PR is ready for merge by the caretaker label Jun 15, 2022
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants