Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong layout with fxHide / fxShow sometimes ignoring breakpoint aliases #181

Closed
phil294 opened this issue Feb 11, 2017 · 5 comments · Fixed by #190
Closed

Wrong layout with fxHide / fxShow sometimes ignoring breakpoint aliases #181

phil294 opened this issue Feb 11, 2017 · 5 comments · Fixed by #190
Assignees
Labels
bug has pr A PR has been created to address this issue
Milestone

Comments

@phil294
Copy link

phil294 commented Feb 11, 2017

Hellou,
#140 has been marked as solved, but I just found another few errors in 2.0.0-beta.5, in regards to fxShow fxHide.md and the alike. Consider the following example for reproducing:

	<div fxHide fxShow.gt-xs>Type 1, row a</div>
	<div fxHide fxShow.gt-xs>Type 1, row b</div>
	<div fxHide fxShow.gt-xs>Type 1, row c</div>
	<br/>
	<div fxShow fxHide.md>Type 2, row a</div>
	<div fxShow fxHide.md>Type 2, row b</div>
	<div fxShow fxHide.md>Type 2, row c</div>

Set your browser to md width and refresh the page. You'd expect to see

Type 1, row a
Type 1, row b
Type 1, row c

, but the output is

Type 1, row a
Type 1, row b

Type 2, row c

which is wrong on multiple levels. It seems the views fix themselves on update. Meaning when you resize the window width to gt-md and back to md, Type 2, row c will then be correctly hidden. And when you resize the window to xs and back to gt-xs, the missing Type 1, row c pops up.

So, I see wrong initialization and weird interference of multiple elements. I might be missing something.

Best regards,

@ThomasBurleson
Copy link
Contributor

@phil294 - I think this is related to #135.

@ThomasBurleson ThomasBurleson added this to the v2.0.0-rc.1 milestone Feb 11, 2017
@ThomasBurleson ThomasBurleson self-assigned this Feb 11, 2017
@ThomasBurleson ThomasBurleson changed the title fxHide / fxShow sometimes ignoring breakpoint aliases Initialization with fxHide / fxShow sometimes ignoring breakpoint aliases Feb 11, 2017
@ThomasBurleson ThomasBurleson changed the title Initialization with fxHide / fxShow sometimes ignoring breakpoint aliases Wrong layout with fxHide / fxShow sometimes ignoring breakpoint aliases Feb 11, 2017
@ThomasBurleson ThomasBurleson added the has pr A PR has been created to address this issue label Feb 18, 2017
@ThomasBurleson
Copy link
Contributor

@phil294 - PR #190 Now renders this:

fix_185

@phil294
Copy link
Author

phil294 commented Feb 18, 2017

Idk if I should test it out or how I could in the first place, but it looks excellent! Good job & thank you very much

@ThomasBurleson
Copy link
Contributor

ThomasBurleson commented Feb 20, 2017

@phil294 - try:

# add upstream if your `origin` points to a fork of the upstream, 
# otherwise just use `origin`

git remote add upstream https://github.com/angular/flex-layout.git

git co master
git pull --rebase upstream master

git pull --rebase upstream fix/issue_181

This should update your local repos with latest from master AND from the PR above.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug has pr A PR has been created to address this issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants