Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fxHide / fxShow ignores breakpoint aliases #140

Closed
phil294 opened this issue Jan 28, 2017 · 2 comments · Fixed by #143
Closed

fxHide / fxShow ignores breakpoint aliases #140

phil294 opened this issue Jan 28, 2017 · 2 comments · Fixed by #143
Assignees
@ThomasBurleson
Labels
bug has pr A PR has been created to address this issue P0 Critical issue that needs to be resolved immediately
Milestone
v2.0.0-beta.5

Comments

@phil294
Copy link

phil294 commented Jan 28, 2017

Tried in both FF & Chrome.
The following span is always hidden, although it should be shown when 'screen and (min-width: 960px) and (max-width: 1279px)'.

<span fxHide fxShow.gt-xs>Text</span>

Another example:

		<span fxHide.lg>text</span>

Never hides.
ThomasBurleson added a commit that referenced this issue Jan 30, 2017
@ThomasBurleson
fix(api): restore orig display mode and more...
49210ac 
*  fxShow and fxHide should restore original display modes when deactivating
*  combination uses of fxHide + fxShow should work properly
*  static uses of `fxHide=""` should hide the hosting elmement

fixes #140, fixes #141.
@ThomasBurleson ThomasBurleson mentioned this issue Jan 30, 2017
Merged
ThomasBurleson added a commit that referenced this issue Jan 30, 2017
@ThomasBurleson
fix(api): restore orig display mode and more...
7f2b07b 
*  fxShow and fxHide should restore original display modes when deactivating
*  combination uses of fxHide + fxShow should work properly
*  static uses of `fxHide=""` should hide the hosting elmement

fixes #140, fixes #141.
ThomasBurleson added a commit that referenced this issue Jan 30, 2017
@ThomasBurleson
fix(api): restore orig display mode and more...
7434744 
*  fxShow and fxHide should restore original display modes when deactivating
*  combination uses of fxHide + fxShow should work properly
*  static uses of `fxHide=""` should hide the hosting elmement

fixes #140, fixes #141.
@ThomasBurleson ThomasBurleson added has pr A PR has been created to address this issue bug labels Jan 30, 2017
@ThomasBurleson ThomasBurleson self-assigned this Jan 30, 2017
@ThomasBurleson ThomasBurleson added this to the v2.0.0-beta.5 milestone Jan 30, 2017
@ThomasBurleson
Copy link
Contributor

Fixed in PR #143

@ThomasBurleson ThomasBurleson added the P0 Critical issue that needs to be resolved immediately label Jan 30, 2017
ThomasBurleson added a commit that referenced this issue Feb 2, 2017
@ThomasBurleson
fix(api): restore orig display mode and more...
c10a575 
*  fxShow and fxHide should restore original display modes when deactivating
*  combination uses of fxHide + fxShow should work properly
*  static uses of `fxHide=""` should hide the hosting elmement

fixes #140, fixes #141.
ThomasBurleson added a commit that referenced this issue Feb 2, 2017
@ThomasBurleson
fix(api): restore orig display mode and more...
3bde7c9 
*  fxShow and fxHide should restore original display modes when deactivating
*  combination uses of fxHide + fxShow should work properly
*  static uses of `fxHide=""` should hide the hosting elmement

fixes #140, fixes #141.
@kara kara closed this as completed in #143 Feb 2, 2017
kara pushed a commit that referenced this issue Feb 2, 2017
@ThomasBurleson @kara
fix(api): restore orig display mode and more... (#143)
d269d73 
fixes #140, fixes #141.
@phil294 phil294 mentioned this issue Feb 11, 2017
Closed
karlhaas pushed a commit to karlhaas/flex-layout that referenced this issue May 3, 2017
@ThomasBurleson @karlhaas
fix(api): restore orig display mode and more... (angular#143)
95718b5 
fixes angular#140, fixes angular#141.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ThomasBurleson ThomasBurleson

Labels
bug has pr A PR has been created to address this issue P0 Critical issue that needs to be resolved immediately
Projects
None yet
Milestone
v2.0.0-beta.5
Development

Successfully merging a pull request may close this issue.

fix(api): restore element's display mode and more... angular/flex-layout
2 participants
@ThomasBurleson @phil294