Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parent container flexbox injection logic is wrong #272

Closed
ThomasBurleson opened this issue Apr 29, 2017 · 1 comment · Fixed by #365
Closed

Parent container flexbox injection logic is wrong #272

ThomasBurleson opened this issue Apr 29, 2017 · 1 comment · Fixed by #365
Assignees
@ThomasBurleson
Labels
has pr A PR has been created to address this issue P2 Issue that is important to resolve as soon as possible
Milestone
v2.0.0-beta.9

Comments

@ThomasBurleson
Copy link
Contributor

When a Flex Layout directive is used on a child element, it expects the parent to work as a FlexBox container. If the parent does not have "display:flex" stylings, then these are injected, inline onto the parent.

If the parent has a classname that defines the FlexBox stylings, these are ignored as only the inline styles are checked. This is wrong.
@ThomasBurleson ThomasBurleson added this to the v2.0.0-beta.9 milestone Apr 29, 2017
@ThomasBurleson ThomasBurleson self-assigned this Apr 29, 2017
This was referenced Apr 29, 2017
Closed
Closed
@ThomasBurleson ThomasBurleson mentioned this issue May 11, 2017
Closed
@ThomasBurleson ThomasBurleson added the P2 Issue that is important to resolve as soon as possible label Jun 22, 2017
@rosslavery rosslavery mentioned this issue Aug 6, 2017
Closed
ThomasBurleson added a commit that referenced this issue Aug 6, 2017
@ThomasBurleson
fix(flexbox): scan flex-direction in css stylesheet
dde889d 
When scanning parent DOM element for flexbox flow direction,
first scan the in element's inline style and then scan the computed
stylesheet for the `flex-direction` value.

Fixes #272, #364.
@ThomasBurleson ThomasBurleson mentioned this issue Aug 6, 2017
Merged
@ThomasBurleson ThomasBurleson added has pr A PR has been created to address this issue and removed in-progress labels Aug 6, 2017
ThomasBurleson added a commit that referenced this issue Aug 6, 2017
@ThomasBurleson
fix(flexbox): scan flex-direction in css stylesheet
07f9a63 
When scanning parent DOM element for flexbox flow direction,
first scan the in element's inline style and then scan the computed
stylesheet for the `flex-direction` value.

Fixes #272, #364.
ThomasBurleson added a commit that referenced this issue Aug 6, 2017
@ThomasBurleson
fix(flexbox): scan flex-direction in css stylesheet
55a7636 
When scanning parent DOM element for flexbox flow direction,
first scan the in element's inline style and then scan the computed
stylesheet for the `flex-direction` value.

Fixes #272, #364.
ThomasBurleson added a commit that referenced this issue Aug 7, 2017
@ThomasBurleson
fix(flexbox): scan flex-direction in css stylesheet
e8beef7 
When scanning parent DOM element for flexbox flow direction,
first scan the in element's inline style and then scan the computed
stylesheet for the `flex-direction` value.

Fixes #272, #364.
ThomasBurleson added a commit that referenced this issue Aug 7, 2017
@ThomasBurleson
fix(flexbox): scan flex-direction in css stylesheet
90f4238 
fxFlex works best if the parent container has flexbox styles assigned
(display, flex-direction, etc.). If not assiged (inline or via stylesheet),
then these styles are auto-injected inline on the DOM parent element.

When scanning parent DOM element for flexbox flow direction,
first scan the in element's inline style and then scan the computed
stylesheet for the `flex-direction` value.

Fixes #272, #364.
ThomasBurleson added a commit that referenced this issue Aug 7, 2017
@ThomasBurleson
fix(flexbox): scan flex-direction in css stylesheet
16f8656 
`fxFlex` works best if the parent container has flexbox styles assigned (display, flex-direction, etc.). If not assigned (inline or via stylesheet), then these styles are auto-injected inline on the DOM parent element.

When scanning parent DOM element for flexbox flow direction, first scan the in element's inline style and then scan the computed stylesheet for the `flex-direction` value.

Fixes #272, #364.
ThomasBurleson added a commit that referenced this issue Aug 7, 2017
@ThomasBurleson
fix(flexbox): scan flex-direction in css stylesheet
4d16c03 
`fxFlex` works best if the parent container has flexbox styles assigned (display, flex-direction, etc.). If not assigned (inline or via stylesheet), then these styles are auto-injected inline on the DOM parent element.

When scanning parent DOM element for flexbox flow direction, first scan the in element's inline style and then scan the computed stylesheet for the `flex-direction` value.

> It is assumed that if the parent element has a `flex-direction` style property set, then the other required properties (display, border-box, etc.)  have also been assigned.

Fixes #272, #364.
mmalerba pushed a commit that referenced this issue Aug 7, 2017
@ThomasBurleson @mmalerba
fix(flexbox): scan flex-direction in css stylesheet (#365)
635c4f5 
`fxFlex` works best if the parent container has flexbox styles assigned (display, flex-direction, etc.). If not assigned (inline or via stylesheet), then these styles are auto-injected inline on the DOM parent element.

When scanning parent DOM element for flexbox flow direction, first scan the in element's inline style and then scan the computed stylesheet for the `flex-direction` value.

> It is assumed that if the parent element has a `flex-direction` style property set, then the other required properties (display, border-box, etc.)  have also been assigned.

Fixes #272, #364.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ThomasBurleson ThomasBurleson

Labels
has pr A PR has been created to address this issue P2 Issue that is important to resolve as soon as possible
Projects
None yet
Milestone
v2.0.0-beta.9
Development

Successfully merging a pull request may close this issue.

fix(flexbox): scan flex-direction in css stylesheet angular/flex-layout
1 participant
@ThomasBurleson