Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fxFlex="1 1 0" sets flex-basis to 100% #280

Closed
adamdport opened this issue May 8, 2017 · 1 comment · Fixed by #629
Closed

fxFlex="1 1 0" sets flex-basis to 100% #280

adamdport opened this issue May 8, 2017 · 1 comment · Fixed by #629
Assignees
@ThomasBurleson @CaerusKaru
Labels
bug enhancement has pr A PR has been created to address this issue P1 Urgent issue that should be resolved before the next re-lease
Milestone
v5.0.0-beta.14

Comments

@adamdport
Copy link

CSS doesn't require units if the value is 0. fxFlex="1 1 0px"(with units) works correctly and sets flex-basis to 0px. However, fxFlex="1 1 0"(without units) erroneously sets it to 100%. flex: 1 1 0; is valid CSS.

Some talk in #277 suggested it might be related to flexbug#4. If someone sets fxFlex="1 1 0" (without units), this API should set flex to 1 1 0px (with units) to satisfy flexbug#4.
@ThomasBurleson ThomasBurleson added this to the Backlog milestone Nov 28, 2017
@ThomasBurleson ThomasBurleson added bug P2 Issue that is important to resolve as soon as possible labels Nov 29, 2017
@ThomasBurleson ThomasBurleson modified the milestones: Backlog, v2.0.0-beta.13 Nov 29, 2017
@ThomasBurleson ThomasBurleson mentioned this issue Dec 15, 2017
Closed
@ThomasBurleson ThomasBurleson added P1 Urgent issue that should be resolved before the next re-lease and removed P2 Issue that is important to resolve as soon as possible labels Dec 15, 2017
@ThomasBurleson ThomasBurleson self-assigned this Dec 15, 2017
CaerusKaru added a commit to CaerusKaru/flex-layout that referenced this issue Feb 25, 2018
@CaerusKaru
fix(fxFlex): apply correct flex-basis stylings
a3204b2 
* Fix for when flex-basis is unitless and 0
* Fix for when no width/height is applied and flex-basis should be
  set

Fixes angular#277
Fixes angular#280
Fixes angular#528
Fixes angular#534
@CaerusKaru CaerusKaru mentioned this issue Feb 25, 2018
Closed
@CaerusKaru CaerusKaru added has pr A PR has been created to address this issue and removed in-progress labels Feb 25, 2018
CaerusKaru added a commit that referenced this issue Feb 25, 2018
@CaerusKaru
fix(fxFlex): apply correct flex-basis stylings
e23e2a0 
* Fix for when flex-basis is unitless and 0
* Fix for when no width/height is applied and flex-basis should be
  set
* Fix for IE flex-basis with calc values
* Fix for SSR properties set to 0

Fixes #277
Fixes #280
Fixes #323
Fixes #528
Fixes #534
@CaerusKaru CaerusKaru mentioned this issue Feb 25, 2018
Merged
CaerusKaru added a commit to CaerusKaru/flex-layout that referenced this issue Feb 25, 2018
@CaerusKaru
fix(fxFlex): apply correct flex-basis stylings
9a1d709 
* Fix for when flex-basis is unitless and 0
* Fix for when no width/height is applied and flex-basis should be
  set
* Fix for IE flex-basis with calc values
* Fix for SSR properties set to 0

Fixes angular#277
Fixes angular#280
Fixes angular#323
Fixes angular#528
Fixes angular#534
CaerusKaru added a commit that referenced this issue Feb 25, 2018
@CaerusKaru
fix(fxFlex): apply correct flex-basis stylings
4ae757f 
* Fix for when flex-basis is unitless and 0
* Fix for when no width/height is applied and flex-basis should be
  set
* Fix for IE flex-basis with calc values
* Fix for SSR properties set to 0

Fixes #277
Fixes #280
Fixes #323
Fixes #528
Fixes #534
CaerusKaru added a commit that referenced this issue Feb 25, 2018
@CaerusKaru
fix(fxFlex): apply correct flex-basis stylings
1a3029f 
* Fix for when flex-basis is unitless and 0
* Fix for when no width/height is applied and flex-basis should be
  set
* Fix for IE flex-basis with calc values
* Fix for SSR properties set to 0

Fixes #277
Fixes #280
Fixes #323
Fixes #528
Fixes #534
CaerusKaru added a commit that referenced this issue Mar 4, 2018
@CaerusKaru
fix(fxFlex): apply correct flex-basis stylings
421a18a 
* Fix for when flex-basis is unitless and 0
* Fix for when no width/height is applied and flex-basis should be
  set
* Fix for IE flex-basis with calc values
* Fix for SSR properties set to 0

Fixes #277
Fixes #280
Fixes #323
Fixes #528
Fixes #534
CaerusKaru added a commit that referenced this issue Mar 9, 2018
@CaerusKaru
fix(fxFlex): apply correct flex-basis stylings
45b29f2 
* Fix for when flex-basis is unitless and 0
* Fix for when no width/height is applied and flex-basis should be
  set
* Fix for IE flex-basis with calc values
* Fix for SSR properties set to 0

Fixes #277
Fixes #280
Fixes #323
Fixes #528
Fixes #534
CaerusKaru added a commit that referenced this issue Mar 9, 2018
@CaerusKaru
fix(fxFlex): apply correct flex-basis stylings
a0ac344 
* Fix for when flex-basis is unitless and 0
* Fix for when no width/height is applied and flex-basis should be
  set
* Fix for IE flex-basis with calc values
* Fix for SSR properties set to 0

Fixes #277
Fixes #280
Fixes #323
Fixes #528
Fixes #534
CaerusKaru added a commit that referenced this issue Mar 9, 2018
@CaerusKaru
fix(fxFlex): apply correct flex-basis stylings
7ab5d34 
* Fix for when flex-basis is unitless and 0
* Fix for when no width/height is applied and flex-basis should be
  set
* Fix for IE flex-basis with calc values
* Fix for SSR properties set to 0

Fixes #277
Fixes #280
Fixes #323
Fixes #528
Fixes #534
CaerusKaru added a commit that referenced this issue Mar 9, 2018
@CaerusKaru
fix(fxFlex): apply correct flex-basis stylings
6f8c7ab 
* Fix for when flex-basis is unitless and 0
* Fix for when no width/height is applied and flex-basis should be
  set
* Fix for IE flex-basis with calc values
* Fix for SSR properties set to 0

Fixes #277
Fixes #280
Fixes #323
Fixes #528
Fixes #534
CaerusKaru added a commit that referenced this issue Mar 9, 2018
@CaerusKaru
fix(fxFlex): apply correct flex-basis stylings (#629)
1e96cea 
* fix for when flex-basis is unitless and 0
* fix for when no width/height is applied and flex-basis should be
  set
* fix for IE flex-basis with calc values
* fix for SSR properties set to 0

Fixes #277
Fixes #280
Fixes #323
Fixes #528
Fixes #534
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ThomasBurleson ThomasBurleson

@CaerusKaru CaerusKaru

Labels
bug enhancement has pr A PR has been created to address this issue P1 Urgent issue that should be resolved before the next re-lease
Projects
None yet
Milestone
v5.0.0-beta.14
4 participants
@ThomasBurleson @CaerusKaru @adamdport @somombo