fix(core): update breakpoint ranges to remove subpixel gaps #1004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In rare cases, browsers resizing my create viewports with subpixel values. Previous mediaQueries had 1 pixel gaps where the bounding ranges do not match. Update the `max-width` values to include subpixel values and eliminate 99.99% of all gaps. Fixes #1001.
ThomasBurleson
force-pushed
the
thomasb/fix-issue-1001
branch
from
e4053bb
to
0ee6796
Compare
CaerusKaru
added
pr: lgtm
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In rare cases, browsers resizing may create viewports with subpixel values.
Previous mediaQueries had 1 pixel gaps where the bounding ranges do not match.
Update the
max-widthvalues to include subpixel values and eliminate 99.99% of all gaps.Fixes #1001.