feat(core): add value multiplication suffix feature #1383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It may be desirable for users to multiply the base values to keep some sort of internal consistency. For instance, in Material Design, values are typically multiplied by 4x or 8x. To support this, we add a new configuration option to the library that plugs in to select directives (at this point, only `fxFlexOffset` and `fxLayoutGap`). To use this feature, use the following syntax: ```ts @NgModule({ imports: [ FlexLayoutModule.withConfig({ multiplier: { value: 4, unit: 'px', } }), ], }) export class MyAppModule {} ``` ```html <div fxFlexOffset="3x">My content</div> ``` This yields: ```html <div style="margin-right: 12px">My content</div> ``` This feature is disabled by default, so to use it, you must explicitly specify both the value and unit of your multiplication.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It may be desirable for users to multiply the base values to keep
some sort of internal consistency. For instance, in Material
Design, values are typically multiplied by 4x or 8x. To support
this, we add a new configuration option to the library that plugs
in to select directives (at this point, only
fxFlexOffsetandfxLayoutGap). To use this feature, use the following syntax:This yields:
This feature is disabled by default, so to use it, you must
explicitly specify both the value and unit of your multiplication.
Fixes #907