feat(flex): detect display precedence in fxLayout directive #1385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some cases, a user may intentionally hide a directive using styling that exists outside of the scope of this library. However, fxLayout had no way of detecting this, or establishing a precedence for pre-existing styles. This adds detection and special caching for pre-styled display attributes on an element. This means that if, at any point in the change detection of the directive for its entire lifespan, it detects that the style has been set to `display: none`, it will use that as the display value in place of what it otherwise would have used. Please note: this means that you need to be more careful when using this functionality! If, for instance, you have functionality that sets `display: none` on a directive, that functionality needs to now take over restoring the correct style for the directive. This is essentially an escape hatch from the library: saying that you know better how to manage these directives. To use this feature, do the following: ```ts @NgModule({ imports: [ FlexLayoutModule.withConfig({detectLayoutDisplay: true}), ], }) export class AppModule {} ``` Your markup should then adapt automatically to the new behavior.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, a user may intentionally hide a directive using
styling that exists outside of the scope of this library. However,
fxLayout had no way of detecting this, or establishing a precedence
for pre-existing styles. This adds detection and special caching
for pre-styled display attributes on an element. This means that if,
at any point in the change detection of the directive for its entire
lifespan, it detects that the style has been set to
display: none,it will use that as the display value in place of what it otherwise
would have used.
Please note: this means that you need to be more careful when using
this functionality! If, for instance, you have functionality that
sets
display: noneon a directive, that functionality needs tonow take over restoring the correct style for the directive. This
is essentially an escape hatch from the library: saying that you
know better how to manage these directives.
To use this feature, do the following:
Your markup should then adapt automatically to the new behavior.
Fixes #1043