Don't rely on `webdriver.promise` or `webdriver.promise.Scheduler` #80

sjelin · 2017-01-19T23:40:19Z

webdriver.promise.ControlFlow.EventType.IDLE can fallback on "IDLE"
new webdriver.promise.Promise(...) should fall back on native promises
isPromise should just be part of maybePromise (not strictly necessary but worth doing since maybePromise needs this anyway)
initJasmineWd(flow) should have flow as optional and default to a mock flow similar to SimpleScheduler but with only execute() and promise() implemented. This is obviously not the prettiest solution but it's probably best given time constraints.

The text was updated successfully, but these errors were encountered:

…ctions While we support `SELENIUM_PROMISE_MANAGER=0` already, we rely on `SimpleScheduler` and some other utility functions which will be going away. This allows jasminewd to work without those utility functions, and even allows people to pass jasminewd their own custom scheduler implementation. Closes angular#80

…ctions While we support `SELENIUM_PROMISE_MANAGER=0` already, we rely on `SimpleScheduler` and some other utility functions which will be going away. This allows jasminewd to work without those utility functions, and even allows people to pass jasminewd their own custom scheduler implementation. This does not fix our tests, which will also break when those utility functions go away. See angular#81 Closes angular#80

…ctions While we support `SELENIUM_PROMISE_MANAGER=0` already, we rely on `SimpleScheduler` and some other utility functions which will be going away after the control flow has been fully deprecated. This commit allows jasminewd to work without those utility functions, and even allows people to pass jasminewd their own custom scheduler implementation. This does not fix our tests, which will also break when those utility functions go away. See angular#81 Closes angular#80

…ctions (#82) While we support `SELENIUM_PROMISE_MANAGER=0` already, we rely on `SimpleScheduler` and some other utility functions which will be going away after the control flow has been fully deprecated. This commit allows jasminewd to work without those utility functions, and even allows people to pass jasminewd their own custom scheduler implementation. This does not fix our tests, which will also break when those utility functions go away. See #81 Closes #80

sjelin mentioned this issue Jan 19, 2017

Remove all direct usage of webdriver.promise angular/protractor#3990

Open

sjelin mentioned this issue Jan 20, 2017

Don't rely on webdriver.promise or webdriver.promise.Scheduler in tests #81

Open

sjelin mentioned this issue Jan 20, 2017

feat(SELENIUM_PROMISE_MANAGER): Don't rely on webdriver.promise fun… #82

Merged

sjelin closed this as completed in #82 Jan 21, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Don't rely on `webdriver.promise` or `webdriver.promise.Scheduler` #80

Don't rely on `webdriver.promise` or `webdriver.promise.Scheduler` #80

sjelin commented Jan 19, 2017 •

edited

Loading

Don't rely on webdriver.promise or webdriver.promise.Scheduler #80

Don't rely on webdriver.promise or webdriver.promise.Scheduler #80

Comments

sjelin commented Jan 19, 2017 • edited Loading

Don't rely on `webdriver.promise` or `webdriver.promise.Scheduler` #80

Don't rely on `webdriver.promise` or `webdriver.promise.Scheduler` #80

sjelin commented Jan 19, 2017 •

edited

Loading