Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Snackbar example in material.angular.io breaks after a few fast clicks #2390

Closed
radoslavpetranov opened this issue Dec 24, 2016 · 1 comment · Fixed by #2392
Closed

Snackbar example in material.angular.io breaks after a few fast clicks #2390

radoslavpetranov opened this issue Dec 24, 2016 · 1 comment · Fixed by #2392
Assignees
@crisbeto

Comments

@radoslavpetranov
Copy link

Bug, feature request, or proposal:

Try double clicking (without pausing) on the example on https://material.angular.io/components/component/snack-bar - after a couple of those you get an exception in the console and the whole app breaks.

What are the steps to reproduce?

Open up the link above, go to examples, try double clicking the "PIZZA PARTY" button 2 or 3 times or just hit it multiple times fast before the message goes down.

Which versions of Angular, Material, OS, browsers are affected?

beta.1

Obviously not a show stopper as nobody would realistically be doing this but I'm just adding the bug report as I noticed the behavior anyway.
crisbeto added a commit to crisbeto/material2 that referenced this issue Dec 24, 2016
@crisbeto
fix(snack-bar): prevent error when opening multiple snack bars in fas…
e44482b 
…t succession

Fixes a runtime error being thrown by Angular when opening multiple snack bars, that have a timeout, in quick succession. The fix waits for the zone to settle before firing the final callbacks.

**Note on testing:** This change is missing a unit test, because I couldn't find a way to trigger the error during tests, however the approach is similar to angular#2219.

Fixes angular#2390.
@crisbeto crisbeto mentioned this issue Dec 24, 2016
Merged
@crisbeto crisbeto self-assigned this Dec 24, 2016
@kara kara closed this as completed in #2392 Jan 3, 2017
kara pushed a commit that referenced this issue Jan 3, 2017
@crisbeto @kara
fix(snack-bar): prevent error when opening multiple snack bars in fas…
161f319 
…t succession (#2392)

Fixes #2390.
@chouclee chouclee mentioned this issue Jan 31, 2017
Closed
@JanStureNielsen JanStureNielsen mentioned this issue Feb 1, 2017
Closed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(snack-bar): prevent error when opening multiple snack bars in fast succession crisbeto/material2
2 participants
@radoslavpetranov @crisbeto