Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

snackbar action button styling when no other md-button is used on the page #2979

Closed
fxck opened this issue Feb 8, 2017 · 2 comments · Fixed by #2991
Closed

snackbar action button styling when no other md-button is used on the page #2979

fxck opened this issue Feb 8, 2017 · 2 comments · Fixed by #2991
Assignees
@crisbeto

Comments

@fxck
Copy link
Contributor

fxck commented Feb 8, 2017 •
edited
Loading

this happens(http://plnkr.co/edit/0x5guGIc5ofmxDyCJ7Sm?p=preview) when there are no md-buttons used on the page

image

when you actually use md-button on the page(http://plnkr.co/edit/oOsUEcDjIkNIi9REGxvA?p=preview), it's fine

image

@crisbeto maybe?
@crisbeto
Copy link
Member

crisbeto commented Feb 8, 2017

Seems weird, will look into it.

@crisbeto crisbeto self-assigned this Feb 8, 2017
crisbeto added a commit to crisbeto/material2 that referenced this issue Feb 8, 2017
@crisbeto
fix(snack-bar): improper button styling and improved handling of long…
b76c2bc 
… text

* Simplifies the snack bar styles, removing some redundancy.
* Fixes the snack bar using the `md-button` styles directly. This causes it to break if another `md-button` isn't on the page in order to import the styles. These changes switch to styling the snack bar button independently since it barely shares any styles with `md-button` anyway.
* Fixes a wrong selector that wasn't styling anything.
* Adds better handling for long text strings inside snack bars.

Fixes angular#2979.
crisbeto added a commit to crisbeto/material2 that referenced this issue Feb 8, 2017
@crisbeto
fix(snack-bar): improper button styling and improved handling of long…
5ce0de5 
… text

* Simplifies the snack bar styles, removing some redundancy.
* Fixes the snack bar using the `md-button` styles directly. This causes it to break if another `md-button` isn't on the page in order to import the styles. These changes switch to styling the snack bar button independently since it barely shares any styles with `md-button` anyway.
* Fixes a wrong selector that wasn't styling anything.
* Adds better handling for long text strings inside snack bars.

Fixes angular#2979.
@crisbeto crisbeto mentioned this issue Feb 8, 2017
Merged
@crisbeto crisbeto added the has pr label Feb 8, 2017
tinayuangao pushed a commit that referenced this issue Feb 9, 2017
@crisbeto @tinayuangao
fix(snack-bar): improper button styling and improved handling of long…
93937e6 
… text (#2991)

* Simplifies the snack bar styles, removing some redundancy.
* Fixes the snack bar using the `md-button` styles directly. This causes it to break if another `md-button` isn't on the page in order to import the styles. These changes switch to styling the snack bar button independently since it barely shares any styles with `md-button` anyway.
* Fixes a wrong selector that wasn't styling anything.
* Adds better handling for long text strings inside snack bars.

Fixes #2979.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(snack-bar): improper button styling and improved handling of long text crisbeto/material2
2 participants
@fxck @crisbeto