Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

md-fab: High Contrast mode has no focus indicator #421

Closed
hansl opened this issue May 10, 2016 · 3 comments · Fixed by #1941
Closed

md-fab: High Contrast mode has no focus indicator #421

hansl opened this issue May 10, 2016 · 3 comments · Fixed by #1941
Assignees
@crisbeto
Labels
Accessibility This issue is related to accessibility (a11y) help wanted The team would appreciate a PR from the community to address this issue P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@hansl
Copy link
Contributor

hansl commented May 10, 2016

At all.
@hansl hansl added the Accessibility This issue is related to accessibility (a11y) label May 10, 2016
@jelbourn jelbourn changed the title Fab Button: High Contrast mode has no focus indicator md-fab: High Contrast mode has no focus indicator May 11, 2016
@jelbourn jelbourn added help wanted The team would appreciate a PR from the community to address this issue P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent labels May 12, 2016
@jelbourn
Copy link
Member

jelbourn commented Nov 4, 2016

@crisbeto since you're on Windows, could you do a pass on the components in high-contrast mode and add styles to make things better?

@crisbeto
Copy link
Member

crisbeto commented Nov 4, 2016 •
edited
Loading

Here's what I got:

  • Fab buttons are barely visible when focused and impossible in high contrast mode.
  • Really hard to see whether raised buttons (accent, primary, warn) are focused.
  • Button toggles don't have any hover indication.
  • Checkboxes don't have focus indication.
  • Radio buttons don't have focus indication.

I'll try to take care of most of them, although the slider and tooltip will need a little bit more work.

crisbeto added a commit to crisbeto/material2 that referenced this issue Nov 4, 2016
@crisbeto
fix(checkbox): missing focus indicator
7235586 
Adds a ripple when a checkbox is focused.

Referencing angular#421.
@crisbeto crisbeto mentioned this issue Nov 4, 2016
Closed
crisbeto added a commit to crisbeto/material2 that referenced this issue Nov 4, 2016
@crisbeto
fix(radio): radio buttons not being a tab stop and missing focus indi…
1e5759a 
…cation

* Fixes the radio buttons not being tabable.
* Adds focus indication to the radio buttons.

Referencing angular#421.
@crisbeto crisbeto mentioned this issue Nov 4, 2016
Closed
crisbeto added a commit to crisbeto/material2 that referenced this issue Nov 4, 2016
@crisbeto
fix(checkbox): missing focus indicator
8210f09 
Adds a ripple when a checkbox is focused.

Referencing angular#421.
crisbeto added a commit to crisbeto/material2 that referenced this issue Nov 4, 2016
@crisbeto
fix(button-toggle): missing hover state
e2de01a 
Adds a hover effect to the button toggles.

Referencing angular#421.
@crisbeto crisbeto mentioned this issue Nov 4, 2016
Merged
jelbourn pushed a commit that referenced this issue Nov 8, 2016
@crisbeto @jelbourn
fix(button-toggle): missing hover state (#1733)
15cd28b 
Adds a hover effect to the button toggles.

Referencing #421.
crisbeto added a commit to crisbeto/material2 that referenced this issue Nov 8, 2016
@crisbeto
fix(radio): radio buttons not being a tab stop and missing focus indi…
fcb3a26 
…cation

* Fixes the radio buttons not being tabable.
* Adds focus indication to the radio buttons.

Referencing angular#421.
rolandjitsu pushed a commit to rolandjitsu/material2 that referenced this issue Nov 10, 2016
@crisbeto @rolandjitsu
fix(button-toggle): missing hover state (angular#1733)
4380a80 
Adds a hover effect to the button toggles.

Referencing angular#421.
crisbeto added a commit to crisbeto/material2 that referenced this issue Nov 19, 2016
@crisbeto
fix(checkbox): missing focus indicator
6ab3016 
Adds a ripple when a checkbox is focused.

Referencing angular#421.
crisbeto added a commit to crisbeto/material2 that referenced this issue Nov 19, 2016
@crisbeto
fix(checkbox): missing focus indicator
82a9d3e 
Adds a ripple when a checkbox is focused.

Referencing angular#421.
crisbeto added a commit to crisbeto/material2 that referenced this issue Nov 20, 2016
@crisbeto
fix: improved accessibility in high contrast mode
d95ddc0 
a11y improvements to the following components in high contrast mode:

* `button` - Adds an outline since only the text was visible. Also inverts the tint since it was hiding the text.
* `card`, `dialog`, `menu`, `snack-bar`, `tooltip` - Adds an outline.
* `select` - Adds an outline and prevents the ripple from hiding the option text.
* `sidenav` - Fixes the backdrop not being opaque.
* `slide-toggle` - Fixes component blending in completely with the background.

Fixes angular#421.
Fixes angular#1769.
@crisbeto crisbeto mentioned this issue Nov 20, 2016
Merged
crisbeto added a commit to crisbeto/material2 that referenced this issue Dec 1, 2016
@crisbeto
fix: improved accessibility in high contrast mode
1206867 
a11y improvements to the following components in high contrast mode:

* `button` - Adds an outline since only the text was visible. Also inverts the tint since it was hiding the text.
* `card`, `dialog`, `menu`, `snack-bar`, `tooltip` - Adds an outline.
* `select` - Adds an outline and prevents the ripple from hiding the option text.
* `sidenav` - Fixes the backdrop not being opaque.
* `slide-toggle` - Fixes component blending in completely with the background.

Fixes angular#421.
Fixes angular#1769.
crisbeto added a commit to crisbeto/material2 that referenced this issue Dec 2, 2016
@crisbeto
fix(radio): radio buttons not being a tab stop and missing focus indi…
2b704bb 
…cation

* Fixes the radio buttons not being tabable.
* Adds focus indication to the radio buttons.

Referencing angular#421.
crisbeto added a commit to crisbeto/material2 that referenced this issue Dec 2, 2016
@crisbeto
fix(radio): radio buttons not being a tab stop and missing focus indi…
084add4 
…cation

* Fixes the radio buttons not being tabable.
* Adds focus indication to the radio buttons.

Referencing angular#421.
crisbeto added a commit to crisbeto/material2 that referenced this issue Dec 2, 2016
@crisbeto
fix: improved accessibility in high contrast mode
fd6d18a 
a11y improvements to the following components in high contrast mode:

* `button` - Adds an outline since only the text was visible. Also inverts the tint since it was hiding the text.
* `card`, `dialog`, `menu`, `snack-bar`, `tooltip` - Adds an outline.
* `select` - Adds an outline and prevents the ripple from hiding the option text.
* `sidenav` - Fixes the backdrop not being opaque.
* `slide-toggle` - Fixes component blending in completely with the background.

Fixes angular#421.
Fixes angular#1769.
mmalerba pushed a commit that referenced this issue Dec 5, 2016
@crisbeto @mmalerba
fix(a11y): improved accessibility in high contrast mode (#1941)
5cf7d17 
* fix: improved accessibility in high contrast mode

a11y improvements to the following components in high contrast mode:

* `button` - Adds an outline since only the text was visible. Also inverts the tint since it was hiding the text.
* `card`, `dialog`, `menu`, `snack-bar`, `tooltip` - Adds an outline.
* `select` - Adds an outline and prevents the ripple from hiding the option text.
* `sidenav` - Fixes the backdrop not being opaque.
* `slide-toggle` - Fixes component blending in completely with the background.

Fixes #421.
Fixes #1769.

* Replace the "border" instances with "outline".

* Move the overlay coloring to the button theme.

* Move the overlay color back to the button base styles.
crisbeto added a commit to crisbeto/material2 that referenced this issue Dec 18, 2016
@crisbeto
fix(checkbox): missing focus indicator
c4712de 
Adds a ripple when a checkbox is focused.

Referencing angular#421.
@BenDevelopment BenDevelopment mentioned this issue Nov 29, 2018
Closed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

Labels
Accessibility This issue is related to accessibility (a11y) help wanted The team would appreciate a PR from the community to address this issue P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: improved accessibility in high contrast mode crisbeto/material2
4 participants
@robertmesserle @hansl @jelbourn @crisbeto