This repository has been archived by the owner on Jul 29, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Restarting forked browsers is broken #3896
Comments
sjelin
added a commit
to sjelin/protractor
that referenced
this issue
Jan 23, 2017
Also allows `browser.restart` to work when the control flow is disabled, and fixes it for forked browsers. Closes angular#3899 and angular#3896
sjelin
added a commit
to sjelin/protractor
that referenced
this issue
Jan 23, 2017
Also allows `browser.restart` to work when the control flow is disabled, and fixes it for forked browsers. Closes angular#3899 and angular#3896
sjelin
added a commit
to sjelin/protractor
that referenced
this issue
Jan 25, 2017
Also allows `browser.restart` to work when the control flow is disabled, and fixes it for forked browsers. Closes angular#3899 and angular#3896
sjelin
added a commit
to sjelin/protractor
that referenced
this issue
Jan 26, 2017
Also allows `browser.restart` to work when the control flow is disabled, and fixes it for forked browsers. Closes angular#3899 and angular#3896
sjelin
added a commit
to sjelin/protractor
that referenced
this issue
Jan 27, 2017
Also allows `browser.restart` to work when the control flow is disabled, and fixes it for forked browsers. Closes angular#3899 and angular#3896
Fixed by b77cb92 |
igniteram
pushed a commit
to igniteram/protractor
that referenced
this issue
Feb 21, 2017
Also allows `browser.restart` to work when the control flow is disabled, and fixes it for forked browsers. Closes angular#3899 and angular#3896
1 task
1 task
bodyduardU
pushed a commit
to bodyduardU/protractor
that referenced
this issue
Dec 5, 2022
Also allows `browser.restart` to work when the control flow is disabled, and fixes it for forked browsers. Closes angular/protractor#3899 and angular/protractor#3896
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Let's say you do the following:
Because
restart
assumes it's being called against the global browser instance, the globalbrowser
instance will be overwritten with the restartedb2
instance, andb2
will still be pointing to original (now closed) forked instance.I propose we have
restart
return the new instance. We can still overwrite the global instance when appropriate too (just add anif
statement here). So now the code will be:Whatever we end up doing to
forkNewDriverInstance
in #3892 we'll have to also do torestart
forasync
/await
users.The text was updated successfully, but these errors were encountered: