You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jul 29, 2024. It is now read-only.
There are a couple different places, scattered throughout out codebase, where we force ManagedPromise accidentally. As far as I've noticed, this happens in one of the following ways:
We use wdpromise.fulfilled, which is actually deprecated. Luckily, we can just switch to WebDriver.promise.when.
We use wdpromise.defer. We can get around this with new wdpromise.controlFlow().promise(...), which follows the same syntax as for ES6 promises. (We only use wdpromise.defer in the debugger, which has a separate issue: Debugger needs to work with the WebDriver control flow turned off #3901)
(I may add to this list if I find more) (I did not)
The text was updated successfully, but these errors were encountered:
After #4017 gets merged in, the only instances of wdpromise.defer will be in lib/debugger.ts. I'm making a note in the corresponding issue (#3901), and I'm limiting the scope of this issue to wdpromise.fulfilled
sjelin
added a commit
to sjelin/protractor
that referenced
this issue
Jan 26, 2017
There are a couple different places, scattered throughout out codebase, where we force
ManagedPromise
accidentally. As far as I've noticed, this happens in one of the following ways:wdpromise.fulfilled
, which is actually deprecated. Luckily, we can just switch toWebDriver.promise.when
.We use(We only usewdpromise.defer
. We can get around this withnew wdpromise.controlFlow().promise(...)
, which follows the same syntax as for ES6 promises.wdpromise.defer
in the debugger, which has a separate issue: Debugger needs to work with the WebDriver control flow turned off #3901)(I may add to this list if I find more)(I did not)The text was updated successfully, but these errors were encountered: