-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Typings issue since @types/jasmine update #4176
Comments
Thanks for noting this. Can you pin your types in the meantime to resolve this? |
Sure, it's already done 😉 |
yep :-( I also observed this for the line Downgraded jasmine typings to |
For Jasmine tests you can use |
* Upgrades outdated development dependencies to the latest versions. * Skipped upgrading Autoprefixer due to a breaking change with the Browserlist. * Skipped upgrading UglifyJS due to unresolved issues in UglifyJS3 * Skipped upgrading google-closure-compiler due to alexeagle/closure-compiler-angular-bundling#30 * Skipped upgrading jasmine types because they now enforce types in `expect` calls (which is nice) but for Protractor the `expect` automatically unwraps promises (See angular/protractor#4176)
* Upgrades outdated development dependencies to the latest versions. * Skipped upgrading Autoprefixer due to a breaking change with the Browserlist. * Skipped upgrading UglifyJS due to unresolved issues in UglifyJS3 * Skipped upgrading google-closure-compiler due to alexeagle/closure-compiler-angular-bundling#30 * Skipped upgrading jasmine types because they now enforce types in `expect` calls (which is nice) but for Protractor the `expect` automatically unwraps promises (See angular/protractor#4176)
* Upgrades outdated development dependencies to the latest versions. * Skipped upgrading Autoprefixer due to a breaking change with the Browserlist. * Skipped upgrading UglifyJS due to unresolved issues in UglifyJS3 * Skipped upgrading google-closure-compiler due to alexeagle/closure-compiler-angular-bundling#30 * Skipped upgrading jasmine types because they now enforce types in `expect` calls (which is nice) but for Protractor the `expect` automatically unwraps promises (See angular/protractor#4176)
* build: upgrade dev dependencies * Upgrades outdated development dependencies to the latest versions. * Skipped upgrading Autoprefixer due to a breaking change with the Browserlist. * Skipped upgrading UglifyJS due to unresolved issues in UglifyJS3 * Skipped upgrading google-closure-compiler due to alexeagle/closure-compiler-angular-bundling#30 * Skipped upgrading jasmine types because they now enforce types in `expect` calls (which is nice) but for Protractor the `expect` automatically unwraps promises (See angular/protractor#4176) * Lock jasmine types
expect( its worked for me |
@ChristianStornowski still not working even with |
Here are my settings for package.json
for tsconfig.json
This is working with current IntellIJ for me. |
@ChristianStornowski Thanks, I found why it wasn't working! I'm using "types": [
"jasmine",
"node"
] changing it to: "types": [
"jasmine",
"jasminewd2",
"node"
] make it work! |
This bumps jasmine types to 2.5.53. The version was previously pinned down to 2.5.45, because more recent versions weren't playing nice with Protractor and lead to errors like angular/protractor#4176 The proper fix appears to be the one mentioned in the Protractor issue: add `@types/jasminewd2` typings, and add these typings to the tsconfig for e2e tests. [jasminewd](https://github.com/angular/jasminewd) is the adapter used by Protractor to handle the async part.
This bumps jasmine types to 2.5.53. The version was previously pinned down to 2.5.45, because more recent versions weren't playing nice with Protractor and lead to errors like angular/protractor#4176 The proper fix appears to be the one mentioned in the Protractor issue: add `@types/jasminewd2` typings, and add these typings to the tsconfig for e2e tests. [jasminewd](https://github.com/angular/jasminewd) is the adapter used by Protractor to handle the async part.
This bumps jasmine types to 2.5.53. The version was previously pinned down to 2.5.45, because more recent versions weren't playing nice with Protractor and lead to errors like angular/protractor#4176 The proper fix appears to be the one mentioned in the Protractor issue: add `@types/jasminewd2` typings, and add these typings to the tsconfig for e2e tests. [jasminewd](https://github.com/angular/jasminewd) is the adapter used by Protractor to handle the async part.
This bumps jasmine types to 2.5.53. The version was previously pinned down to 2.5.45, because more recent versions weren't playing nice with Protractor and lead to errors like angular/protractor#4176 The proper fix appears to be the one mentioned in the Protractor issue: add `@types/jasminewd2` typings, and add these typings to the tsconfig for e2e tests. [jasminewd](https://github.com/angular/jasminewd) is the adapter used by Protractor to handle the async part.
This bumps jasmine types to 2.5.53. The version was previously pinned down to 2.5.45, because more recent versions weren't playing nice with Protractor and lead to errors like angular/protractor#4176 The proper fix appears to be the one mentioned in the Protractor issue: add `@types/jasminewd2` typings, and add these typings to the tsconfig for e2e tests. [jasminewd](https://github.com/angular/jasminewd) is the adapter used by Protractor to handle the async part.
This bumps jasmine types to 2.5.53. The version was previously pinned down to 2.5.45, because more recent versions weren't playing nice with Protractor and lead to errors like angular/protractor#4176 The proper fix appears to be the one mentioned in the Protractor issue: add `@types/jasminewd2` typings, and add these typings to the tsconfig for e2e tests. [jasminewd](https://github.com/angular/jasminewd) is the adapter used by Protractor to handle the async part.
* chore(package): update @types/jasmine to version 2.5.54 * Adding @types/jasminewd2 (cp. angular/protractor#4176)
Any updates after 13 months guys ? |
@mruzek What kind of update do you expect? There is nothing broken here. You have two options:
|
This bumps jasmine types to 2.5.53. The version was previously pinned down to 2.5.45, because more recent versions weren't playing nice with Protractor and lead to errors like angular/protractor#4176 The proper fix appears to be the one mentioned in the Protractor issue: add `@types/jasminewd2` typings, and add these typings to the tsconfig for e2e tests. [jasminewd](https://github.com/angular/jasminewd) is the adapter used by Protractor to handle the async part.
Since the release of
@types/[email protected]
I have this issue while running my protractor tests with typescript:This trace back to this code:
In the new jasmine types, the
expect
typings are now enforced (it wasn't the case before).It seems that the protractor jasmine overrides that wait for Promises to resolve before performing the match needs to extends the typings for this to work correctly.
Bug report
6.x
5.x
2.x
PhantomJS
osx 10.12.11
The text was updated successfully, but these errors were encountered: