This repository has been archived by the owner on Jul 29, 2024. It is now read-only.
feat(browser.ready): make browser.ready wait for all async setup work
#4015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliemr
reviewed
Jan 26, 2017
| this.resetUrl = 'about:blank'; | ||
| } | ||
| }); | ||
| this.ready = this.driver.controlFlow() |
There was a problem hiding this comment.
Why do we need the wrapping in execute here?
There was a problem hiding this comment.
this.driver.getSession() is not necessarily a promise which is on the control flow, so this is needed to ensure that the other stuff we stick onto browser.ready is on the control flow
| browser_.driver.getCurrentUrl().then((url: string) => { | ||
| newBrowser.get(url); | ||
| }); | ||
| newBrowser.ready = wdpromise.all([newBrowser.ready, browser_.driver.getCurrentUrl()]) |
There was a problem hiding this comment.
This seems simpler as:
newBrowser.ready = newBrowser.ready().then(() => {
return browser_.driver.getCurrentUrl();
}).then((url) => {
return newBrowser.get(url);
}).then(() => {
return newBrowser;
});instead of messing with the promise.all.
sjelin
commented
Jan 26, 2017
| this.resetUrl = 'about:blank'; | ||
| } | ||
| }); | ||
| this.ready = this.driver.controlFlow() |
There was a problem hiding this comment.
this.driver.getSession() is not necessarily a promise which is on the control flow, so this is needed to ensure that the other stuff we stick onto browser.ready is on the control flow
| browser_.driver.getCurrentUrl().then((url: string) => { | ||
| newBrowser.get(url); | ||
| }); | ||
| newBrowser.ready = wdpromise.all([newBrowser.ready, browser_.driver.getCurrentUrl()]) |
juliemr
approved these changes
Jan 26, 2017
sjelin
added a commit
that referenced
this pull request
Jan 26, 2017
sjelin
added a commit
to sjelin/protractor
that referenced
this pull request
Jan 27, 2017
igniteram
pushed a commit
to igniteram/protractor
that referenced
this pull request
Feb 21, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3900