Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Trigger Warnings #82

Merged
merged 9 commits into from
Oct 1, 2021
Merged

Add Trigger Warnings #82

merged 9 commits into from
Oct 1, 2021

Conversation

neelr
Copy link
Contributor

@neelr neelr commented Aug 24, 2021

Fixes #64

@vercel
Copy link

vercel bot commented Aug 24, 2021

Someone is attempting to deploy a commit to a Personal Account owned by @anirudhb on Vercel.

@anirudhb first needs to authorize it.

@anirudhb anirudhb marked this pull request as draft August 24, 2021 00:45
@neelr neelr marked this pull request as ready for review August 24, 2021 00:48
anirudhb
anirudhb requested changes Aug 24, 2021
View reviewed changes
Copy link
Owner

@anirudhb anirudhb left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nits, also I think this fork is out of date(?)

lib/main.ts Outdated Show resolved Hide resolved
lib/main.ts Outdated Show resolved Hide resolved
pages/api/interaction_work.ts Outdated Show resolved Hide resolved
@neelr neelr requested a review from anirudhb August 24, 2021 01:10
@neelr
Copy link
Contributor Author

neelr commented Aug 24, 2021

nits, also I think this fork is out of date(?)

I thinkkk its up to date with the master branch, I pulled before working, and the latest commit is there

anirudhb
anirudhb approved these changes Sep 1, 2021
View reviewed changes
Copy link
Owner

@anirudhb anirudhb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, need to test this sometime. Do you mind setting up your own prox2 instance to test this and DM me the results on slack?

lib/main.ts Outdated Show resolved Hide resolved
@neelr
Copy link
Contributor Author

neelr commented Oct 1, 2021

I checked it in #botspam, should work and have all the bugs ironed out

@anirudhb
Copy link
Owner

anirudhb commented Oct 1, 2021

Thanks so much for sticking with me on this! Ready to merge :)

@anirudhb anirudhb merged commit 582a0c5 into anirudhb:master Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anirudhb anirudhb anirudhb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Trigger warnings
2 participants
@neelr @anirudhb