Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub Oauth registration and login #101

Open
1 of 4 tasks
isabelcosta opened this issue Feb 24, 2021 · 7 comments · May be fixed by #109
Open
1 of 4 tasks

Add GitHub Oauth registration and login #101

isabelcosta opened this issue Feb 24, 2021 · 7 comments · May be fixed by #109
Assignees
Labels
Category: Coding Changes to code base or refactored code that doesn't fix a bug. Type: Enhancement New feature or request.

Comments

@isabelcosta
Copy link
Member

Description

As a developer,
I need to implement GitHub sign on,
so that I can allow GitHub users to login using their GitHub account.

For being able to use the application, the user has to create a new account and confirm the email just to login. It's a long process. So by having GitHub OAuth we can make the process shorter for users who have a GitHub account.

Acceptance Criteria

Update [Required]

  • Implement GitHub OAuth login and registration
  • Write unit tests for the updates ^^

Definition of Done

  • All of the required items are completed.
  • Approval by 1 mentor.

Estimation

8 hours

@isabelcosta isabelcosta added Category: Coding Changes to code base or refactored code that doesn't fix a bug. Status: Available Issue was approved and available to claim or abandoned for over 3 days. Type: Enhancement New feature or request. labels Feb 24, 2021
@jalajcodes
Copy link
Member

Can I work on it? @isabelcosta

@codesankalp
Copy link
Member

@jalajcodes You are assigned to #63.

@isabelcosta I want to give it a try.

@isabelcosta isabelcosta removed the Status: Available Issue was approved and available to claim or abandoned for over 3 days. label Feb 25, 2021
@isabelcosta
Copy link
Member Author

assigned to @codesankalp because you're not assigned to anything

@codesankalp
Copy link
Member

@isabelcosta Can I create an issue on the frontend also for this and start working on both as I will need the frontend to test the implementation from the backend?

@isabelcosta
Copy link
Member Author

Yes, you can do that and build the feature full stack. Do create the issue and link to this comment of mine and to this issue. @codesankalp

@codesankalp
Copy link
Member

Update: Implemented the Github OAuth on both frontend and backend but facing problem in making jwt authorization. Will solve this problem and make a PR asap.

@isabelcosta
Copy link
Member Author

Awesome @codesankalp I love me some updates 💯 thank you!

codesankalp added a commit to codesankalp/anitab-forms-backend that referenced this issue Mar 4, 2021
Added GitHub Oauth which uses JWT REST API for authenticating users.

Fixes anitab-org#101
codesankalp added a commit to codesankalp/anitab-forms-backend that referenced this issue Mar 4, 2021
Added GitHub Oauth which uses JWT REST API for authenticating users.

Fixes anitab-org#101
codesankalp added a commit to codesankalp/anitab-forms-backend that referenced this issue Mar 7, 2021
Added GitHub Oauth which uses JWT REST API for authenticating users.

Fixes anitab-org#101
codesankalp added a commit to codesankalp/anitab-forms-backend that referenced this issue Mar 16, 2021
Added GitHub Oauth which uses JWT REST API for authenticating users.

Fixes anitab-org#101
codesankalp added a commit to codesankalp/anitab-forms-backend that referenced this issue Apr 2, 2021
Added GitHub Oauth which uses JWT REST API for authenticating users.

Fixes anitab-org#101
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Coding Changes to code base or refactored code that doesn't fix a bug. Type: Enhancement New feature or request.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants