Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup of the project with Django #6

Merged
merged 1 commit into from
Jun 2, 2020
Merged

Setup of the project with Django #6

merged 1 commit into from
Jun 2, 2020

Conversation

bismitaguha
Copy link
Contributor

Description

  • Added README.md with basic setup and contributing instructions
  • Added requirements.txt with the necessary dependencies for the project.

Fixes #5

Type of Change:

  • Code
  • Documentation

Code/Quality Assurance Only

  • Bug fix (non-breaking change which fixes an issue)
  • This change requires a documentation update (software upgrade on readme file)
  • New feature (non-breaking change which adds functionality pre-approved by mentors)

How Has This Been Tested?

The server is up and running and the mentioned URLs in settings.py are working

Checklist:

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials
  • I have commented my code or provided relevant documentation, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged

Code/Quality Assurance Only

  • My changes generate no new warnings

@bismitaguha
Copy link
Contributor Author

@abha224 @Monal5031 @mayburgos Please review! 🎉

@Monal5031 Monal5031 added Category: Coding Changes to code base or refactored code that doesn't fix a bug. Program: GSOC Related to work completed during the Google Summer of Code Program. Status: Needs Review PR needs an additional review or a maintainer's review. labels Jun 1, 2020
Monal5031
Monal5031 approved these changes Jun 2, 2020
View reviewed changes
Copy link
Contributor

@Monal5031 Monal5031 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

abha224
abha224 reviewed Jun 2, 2020
View reviewed changes
README.md Outdated
1. Database Setup
<br>
Before starting with the project create a db in you local using PostgreSQL with the following details. Refer to `main/settings.py` if you have any confusion.
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a new line here, the below lines aren't formatted correctly.

abha224
abha224 reviewed Jun 2, 2020
View reviewed changes
README.md Outdated

1. Database Setup
<br>
Before starting with the project create a db in you local using PostgreSQL with the following details. Refer to `main/settings.py` if you have any confusion.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest you add a few SQL commands( eg : createdb etc) for setting up PostgreSQL

@bismitaguha
Add README with setup instructions
6d2fe07 
Add requirements.txt as basic setup of the project
Update .gitignore
@bismitaguha
Copy link
Contributor Author

@abha224 I have made the respective changes in the previous commit and squashed the new one with the old commit. Please review! 💯

@bismitaguha bismitaguha requested a review from abha224 June 2, 2020 16:49
abha224
abha224 approved these changes Jun 2, 2020
View reviewed changes
Copy link
Contributor

@abha224 abha224 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! The pr looks good to be merged.

@abha224 abha224 merged commit d206e33 into anitab-org:develop Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Monal5031 Monal5031 Monal5031 approved these changes

@abha224 abha224 abha224 approved these changes

@mayburgos mayburgos Awaiting requested review from mayburgos

Assignees
No one assigned
Labels
Category: Coding Changes to code base or refactored code that doesn't fix a bug. Program: GSOC Related to work completed during the Google Summer of Code Program. Status: Needs Review PR needs an additional review or a maintainer's review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

django project setup
3 participants
@bismitaguha @Monal5031 @abha224