Login ui for the website #28

bismitaguha · 2020-06-09T19:53:53Z

Description

Modified login action accordingly
Added Login Component
Added routing for Login

Fixes #16

Type of Change:

Code
User Interface

Code/Quality Assurance Only

New feature (non-breaking change which adds functionality pre-approved by mentors)

How Has This Been Tested?

Currently requires double click to enter Dashboard Page on successful Login

Checklist:

My PR follows the style guidelines of this project
I have performed a self-review of my own code or materials
I have commented my code or provided relevant documentation, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
Any dependent changes have been merged

Code/Quality Assurance Only

My changes generate no new warnings
Any dependent changes have been published in downstream modules

bismitaguha · 2020-06-09T19:56:58Z

@abha224 @sidvenu
Errors arising:

As registration needs confirmation I have removed any redirect from that component.
Login happens successfully on one click, but redirect to dashboard is made on second click.
Whenever Login form is submitted a warning is generated: Form submission canceled because the form is not connected

Please clarify these!

sidvenu · 2020-06-10T05:26:26Z

@bismitaguha the issues are related to each other. When a button is clicked, browsers could interpret it differently to be a submit button (whereas it is a button to run a piece of code, and then use code to navigate away), and thus your onClick and the browser is competing with each other to submit the form.

Try adding type="button" to the button attributes or evt.preventDefault() in the button's onClick function.

sidvenu · 2020-06-10T05:33:25Z

As we talked about in the weekly session, please do try to give separate PRs for each issue. It's hard to go through 22 files with about 1000 LoC additions. Within a single PR, do break it down into logically separate commits.

And please follow the commit message style guide: https://github.com/anitab-org/mentorship-android/wiki/Commit-Message-Style-Guide. Is it possible for you to change the commit messages to follow the style guide?

sidvenu

Please do change the commit messages as per the comment above.

bismitaguha · 2020-06-10T05:35:40Z

@sidvenu I was suggested by @Monal5031 to proceed to further issues and rebase later before merging. So I am doing the same. I hope it's fine.

sidvenu · 2020-06-10T05:38:34Z

@bismitaguha If that is the case, sure, we can use the message style guide while merging. But please do keep the above suggestions in mind for your next PRs 😄.

bismitaguha · 2020-06-10T05:40:43Z

@bismitaguha If that is the case, sure, we can use the message style guide while merging. But please do keep the above suggestions in mind for your next PRs .

I have made separate PRs based on your suggestions in the meeting. I will look into the commit messages. 😊

sidvenu · 2020-06-10T05:44:50Z

Amazing. Let us know if the above solution to the Form submission canceled because the form is not connected error is working.

Monal5031 · 2020-06-10T08:51:41Z

@bismitaguha I think there was a miscommunication, I suggested to start working on a separate branch so that would help you save time while the main PR is in review. I didn't meant to add the changes in same PR

bismitaguha · 2020-06-10T08:55:01Z

This is in a separate branch. The previous PR #27. Once the previous one gets merged I will rebase this. I did that same with the previous issue . It was in backend repo. I hope that's fine?? @Monal5031

Monal5031 · 2020-06-10T08:59:02Z

Ahh okay, by @sidvenu 's comments I thought you made a single PR for different issues. It's okay I guess if the PRs are for different issues just make sure to mark them as WIP with a label or in title.

@sidvenu @abha224 Please let us know if this strategy to save time is okay with you all?

sidvenu · 2020-06-10T09:24:28Z

@Monal5031 if two issues are heavily dependent on each other that it'll hinder developement of one without the other, then absolutely - we can have a single PR for both the issues.

If that is not the case, I feel separate PRs would be ideal - since it is just good open source practice and it prevents big PRs to a certain extent. What do you think?

Monal5031 · 2020-06-10T09:39:07Z

Agreed @sidvenu makes total sense

abha224 · 2020-06-13T13:20:50Z

Login happens successfully on one click, but redirect to dashboard is made on second click.

Whenever Login form is submitted a warning is generated: Form submission canceled because the form is not connected

@bismitaguha Im not able to reproduce the error? can you provide the steps again?

abha224 · 2020-06-16T13:14:21Z

src/components/Login.js

@@ -28,7 +28,7 @@ class Login extends Component {
    })

    submitLogin = () => {
-
+        console.log("hello")


remove this line

sidvenu

Also, please add new lines to the files you've created in the current PR that doesn't have a new line yet.

sidvenu · 2020-06-18T16:55:04Z

package.json

+  "devDependencies": {
+    "prettier": "2.0.5"
  }


Can we move this out of this PR? I've just created an issue - #34 for using prettier. Reason being we may need to format code that is outside the scope of this PR as well.

sidvenu · 2020-06-18T16:55:30Z

src/components/Navbar.js

+        // if(localStorage.getItem('token') !== null){
+            this.props.getInfo()
+            this.props.getUser()
+        // }
+


Comment to be removed?

src/components/Register.js

src/index.js

abha224 · 2020-06-27T07:46:47Z

@bismitaguha can you resolve the conflicts?

Add Routing Add Registration component, actions & reducers

Modify routing Modify Login action

Modify form validation

Remove unnecessary comments

bismitaguha · 2020-06-27T13:37:59Z

@abha224 Merge conflicts resolved!
I feel such conflicts will arise in further PRs too.

bismitaguha requested review from sidvenu, Monal5031 and abha224 June 9, 2020 19:53

sidvenu suggested changes Jun 10, 2020

View reviewed changes

abha224 reviewed Jun 16, 2020

View reviewed changes

bismitaguha requested review from abha224 and sidvenu June 18, 2020 14:25

sidvenu suggested changes Jun 18, 2020

View reviewed changes

bismitaguha requested a review from sidvenu June 22, 2020 13:46

abha224 approved these changes Jun 24, 2020

View reviewed changes

sidvenu suggested changes Jun 25, 2020

View reviewed changes

src/components/Register.js Outdated Show resolved Hide resolved

src/index.js Outdated Show resolved Hide resolved

bismitaguha requested a review from sidvenu June 26, 2020 12:48

sidvenu approved these changes Jun 26, 2020

View reviewed changes

bismitaguha added 3 commits June 27, 2020 18:59

Add Navbar component

ca6113c

Add Routing Add Registration component, actions & reducers

Add login component

c3e4139

Modify routing Modify Login action

Remove warnings

2b6d101

Modify form validation

bismitaguha added 4 commits June 27, 2020 19:02

Modify callback() function to fix redirect

2754425

Add form validation to Login UI

920cf50

Add new line to end of file

5da258a

Remove unnecessary comments

style: Modified variable names and PR related changes

b5a0ef7

bismitaguha force-pushed the login-ui branch from 6e5328e to b5a0ef7 Compare June 27, 2020 13:35

abha224 merged commit 4e0a950 into anitab-org:develop Jun 27, 2020

abha224 changed the title ~~[WIP]: Login ui~~ Login ui for the website Jun 27, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Login ui for the website #28

Login ui for the website #28

bismitaguha commented Jun 9, 2020 •

edited

Loading

bismitaguha commented Jun 9, 2020

sidvenu commented Jun 10, 2020

sidvenu commented Jun 10, 2020

sidvenu left a comment

bismitaguha commented Jun 10, 2020

sidvenu commented Jun 10, 2020 •

edited

Loading

bismitaguha commented Jun 10, 2020 •

edited

Loading

sidvenu commented Jun 10, 2020

Monal5031 commented Jun 10, 2020

bismitaguha commented Jun 10, 2020

Monal5031 commented Jun 10, 2020

sidvenu commented Jun 10, 2020

Monal5031 commented Jun 10, 2020

abha224 commented Jun 13, 2020

abha224 Jun 16, 2020

sidvenu left a comment

sidvenu Jun 18, 2020

sidvenu Jun 18, 2020

abha224 commented Jun 27, 2020

bismitaguha commented Jun 27, 2020

Login ui for the website #28

Login ui for the website #28

Conversation

bismitaguha commented Jun 9, 2020 • edited Loading

Description

Type of Change:

How Has This Been Tested?

Checklist:

bismitaguha commented Jun 9, 2020

sidvenu commented Jun 10, 2020

sidvenu commented Jun 10, 2020

sidvenu left a comment

Choose a reason for hiding this comment

bismitaguha commented Jun 10, 2020

sidvenu commented Jun 10, 2020 • edited Loading

bismitaguha commented Jun 10, 2020 • edited Loading

sidvenu commented Jun 10, 2020

Monal5031 commented Jun 10, 2020

bismitaguha commented Jun 10, 2020

Monal5031 commented Jun 10, 2020

sidvenu commented Jun 10, 2020

Monal5031 commented Jun 10, 2020

abha224 commented Jun 13, 2020

abha224 Jun 16, 2020

Choose a reason for hiding this comment

sidvenu left a comment

Choose a reason for hiding this comment

sidvenu Jun 18, 2020

Choose a reason for hiding this comment

sidvenu Jun 18, 2020

Choose a reason for hiding this comment

abha224 commented Jun 27, 2020

bismitaguha commented Jun 27, 2020

bismitaguha commented Jun 9, 2020 •

edited

Loading

sidvenu commented Jun 10, 2020 •

edited

Loading

bismitaguha commented Jun 10, 2020 •

edited

Loading