Add feature to create, view, edit & delete forms #39

bismitaguha · 2020-07-03T23:24:55Z

Description

Added viewing for forms
Added moment.js for display of dates
Add delete feature for forms
Add delete confirmation before finally deleting the form
Option for adding new fields to a form and editing the fields

Fixes #19

Type of Change:

Code
User Interface

Code/Quality Assurance Only

New feature (non-breaking change which adds functionality pre-approved by mentors)

How Has This Been Tested?

UI

Checklist:

My PR follows the style guidelines of this project
I have performed a self-review of my own code or materials
Any dependent changes have been merged

Code/Quality Assurance Only

My changes generate no new warnings
Any dependent changes have been published in downstream modules

bismitaguha · 2020-07-03T23:27:02Z

@abha224 @sidvenu As I had mentioned, work on this PR is left, but you can review this part. Also, there is a slight change in the UI than mentioned in the design, but I don't know why this looks more balanced and prettier. If you want me to shift to the mentioned design, I will but please give this view a thought. 😃

sidvenu · 2020-07-04T11:47:00Z

src/components/Form.js

+class Form extends Component {
+    constructor(props) {
+        super(props)
+    }
+
+    componentDidMount() {
+        this.props.getInfo()
+    }

-export default class Form extends Component {
    render() {
+        const { userinfo } = this.props
+        const type = userinfo ? ( userinfo[0] ? userinfo[0].user_type : null ) : 'student'
        return (
-            <div>
-                forms
+            <div className='form'>
+                <div className='inside'>
+                {
+                    type === 'admin'?
+                    <>
+                    <Header>Published Forms</Header>
+                    <PublishedForm />
+                    <Divider />
+                    <Header>Unpublished Forms</Header>
+                    <UnpublishedForm />
+                    </>
+                    : <PublishedForm />
+                }
+                </div>
            </div>
        )
    }
 }
+
+Form.propTypes = {
+    userinfo: PropTypes.array.isRequired
+};
+
+const mapStateToProps = state => ({
+    formerror: state.form.formerror,
+    userinfo: state.info.userinfo,
+})
+
+export default connect(
+    mapStateToProps,
+    { postForm, getInfo }
+)(Form)


Could you explain this component? I'm not able to wrap my head around it.

This is supposed to render based on condition of which user is logged in.

sidvenu · 2020-07-04T17:10:46Z

Could you increase the verbosity of the names of the different files?
The file name of Form.js and the component name does not match.

Do address the above :)

Add display for fields

bismitaguha · 2020-07-17T17:11:06Z

@sidvenu @abha224 The state of the new fields are not getting updated in the frontend. The object is not getting created properly. So please look into it!!

sidvenu · 2020-07-17T18:50:10Z

@bismitaguha I tried looking into the bug you described in our 1:1, I'm not able to track it down just by code review. Will test it out and try to find out the bug soon.

sidvenu · 2020-07-20T09:56:13Z

@bismitaguha did you get any leads on this bug (I didn't)? If not, we can use today's OSP weekly session to debug it if we have time in the end.

cc @abha224

abha224 · 2020-07-20T14:59:22Z

@bismitaguha I was going through the working of this branch, and seems like theres a problem in user info update. Did you modify the code for that ?

bismitaguha · 2020-07-20T15:00:58Z

@bismitaguha I was going through the working of this branch, and seems like theres a problem in user info update. Did you modify the code for that ?

There is a warning I guess, but this won't be the PR where I make that change, I haven't made any changes to that component in this PR.

bismitaguha · 2020-07-21T17:26:32Z

Error displayed on state change

src/components/Questions.js

Add feature to add options wherever required

bismitaguha · 2020-07-22T21:31:26Z

src/actions/form.js

abha224 · 2020-07-23T15:36:02Z

@bismitaguha There are 2 class components 'Form' and 'Forms' in forms.js and dashboard.js. And even the class name for Submissions.js is Form. Pls modify these class names appropriately to avoid duplicates.
Also, there are hardly any comments in the code , pls add them . Even if the method names are self explanatory, it is a good practice to write comments so that anyone who tries to checks this project can easily understand whats achieved through the code rather than going through it line by line.

sidvenu

Please make the changes @abha224 requested. Were the bugs you talked about previously fixed?

sidvenu

LGTM. One general suggestion is for you to add more comments wherever it makes sense - but it has been 4 weeks already, let's get this PR merged.

abha224 · 2020-07-28T13:25:49Z

@bismitaguha the buttons on the form are not functional? Also, the forms are not being retained after creation?

(pls ignore spelling errors in gif )

bismitaguha · 2020-07-28T13:34:35Z

@bismitaguha the buttons on the form are not functional? Also, the forms are not being retained after creation?

(pls ignore spelling errors in gif )

Weirdly create function in mine is working fine....We can discuss this in Siddharth's office hours today. I guess maybe you are in some other branch or something, just like the problem was previous time!!! @abha224

feat: Add feature to view forms, Published and Unpublished separately

d792aa8

bismitaguha requested review from sidvenu and abha224 July 3, 2020 23:24

feat: Add delete feature for forms along with delete confirmation

46ffc27

sidvenu reviewed Jul 4, 2020

View reviewed changes

bismitaguha added 2 commits July 4, 2020 21:17

feat: Add feature for creating forms

2521cd0

abc

cec6800

bismitaguha added 3 commits July 11, 2020 20:23

feat: Add update feature for forms

b946c7f

Add display for fields

Modify edit and delete features

500c6f9

feat: Add feature to update fields

27a3f8f

bismitaguha force-pushed the form-ui branch from fd73033 to 27a3f8f Compare July 16, 2020 21:56

sidvenu mentioned this pull request Jul 20, 2020

Share form via link #40

Merged

5 tasks

sidvenu suggested changes Jul 21, 2020

View reviewed changes

src/components/Questions.js Outdated Show resolved Hide resolved

feat: Add feature to add new fields

dce80c3

Add feature to add options wherever required

bismitaguha requested a review from sidvenu July 22, 2020 21:31

bismitaguha changed the title ~~[WIP]: Add feature to create, view, edit & delete forms~~ Add feature to create, view, edit & delete forms Jul 22, 2020

abha224 reviewed Jul 23, 2020

View reviewed changes

src/actions/form.js Outdated Show resolved Hide resolved

sidvenu suggested changes Jul 23, 2020

View reviewed changes

bismitaguha added 2 commits July 25, 2020 20:21

style: Add comments

f5df6a9

feat: Modify URLs and routes for forms

77fd273

sidvenu previously approved these changes Jul 28, 2020

View reviewed changes

bug: Modify questions state

39d2edd

bismitaguha dismissed sidvenu’s stale review via 39d2edd August 1, 2020 18:30

sidvenu approved these changes Aug 1, 2020

View reviewed changes

abha224 approved these changes Aug 1, 2020

View reviewed changes

bismitaguha changed the title ~~Add feature to create, view, edit & delete forms~~ Add feature to create, view, edit & delete forms and fields Aug 1, 2020

bismitaguha changed the title ~~Add feature to create, view, edit & delete forms and fields~~ Add feature to create, view, edit & delete forms Aug 1, 2020

sidvenu merged commit ddd4712 into anitab-org:develop Aug 1, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add feature to create, view, edit & delete forms #39

Add feature to create, view, edit & delete forms #39

bismitaguha commented Jul 3, 2020 •

edited by abha224

Loading

bismitaguha commented Jul 3, 2020

sidvenu Jul 4, 2020

bismitaguha Jul 4, 2020

sidvenu commented Jul 4, 2020

bismitaguha commented Jul 17, 2020

sidvenu commented Jul 17, 2020

sidvenu commented Jul 20, 2020 •

edited

Loading

abha224 commented Jul 20, 2020

bismitaguha commented Jul 20, 2020

bismitaguha commented Jul 21, 2020

bismitaguha commented Jul 22, 2020

abha224 commented Jul 23, 2020

sidvenu left a comment

sidvenu left a comment

abha224 commented Jul 28, 2020

bismitaguha commented Jul 28, 2020 •

edited

Loading

Add feature to create, view, edit & delete forms #39

Add feature to create, view, edit & delete forms #39

Conversation

bismitaguha commented Jul 3, 2020 • edited by abha224 Loading

Description

Type of Change:

How Has This Been Tested?

UI

Checklist:

bismitaguha commented Jul 3, 2020

sidvenu Jul 4, 2020

Choose a reason for hiding this comment

bismitaguha Jul 4, 2020

Choose a reason for hiding this comment

sidvenu commented Jul 4, 2020

bismitaguha commented Jul 17, 2020

sidvenu commented Jul 17, 2020

sidvenu commented Jul 20, 2020 • edited Loading

abha224 commented Jul 20, 2020

bismitaguha commented Jul 20, 2020

bismitaguha commented Jul 21, 2020

bismitaguha commented Jul 22, 2020

abha224 commented Jul 23, 2020

sidvenu left a comment

Choose a reason for hiding this comment

sidvenu left a comment

Choose a reason for hiding this comment

abha224 commented Jul 28, 2020

bismitaguha commented Jul 28, 2020 • edited Loading

bismitaguha commented Jul 3, 2020 •

edited by abha224

Loading

sidvenu commented Jul 20, 2020 •

edited

Loading

bismitaguha commented Jul 28, 2020 •

edited

Loading