Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Revamp event card and add event info modal popup #244

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Feat: Revamp event card and add event info modal popup #244

wants to merge 1 commit into from

Conversation

Rahulm2310
Copy link
Contributor

Description

Shorten the text in the events cards, add a Read more button in the card and add a new event details modal popup to display full details of event.

Fixes #237

Type of Change:

Delete irrelevant options.

  • Code
  • User Interface

Code/Quality Assurance Only

  • New feature (non-breaking change which adds functionality pre-approved by mentors)

How Has This Been Tested?

anitab-events-fix

Checklist:

Delete irrelevant options.

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials
  • I have commented my code or provided relevant documentation, particularly in hard-to-understand areas

Code/Quality Assurance Only

  • My changes generate no new warnings

@Rahulm2310
Copy link
Contributor Author

Rahulm2310 commented Feb 27, 2021 •
edited
Loading

@nandini45 @keshakaneria Can you please review this PR. Thanks 🙂

@keshakaneria
Copy link
Member

@Rahulm2310 Can we keep 3 in a row? Currently there seems a lot of space on right and a bit on left side of card. What do you say @nandini45?
Otherwise the modal looks perfect 👍.

@Rahulm2310
Copy link
Contributor Author

@keshakaneria Yes it can be but do we need to discuss it with the design team first?

@keshakaneria
Copy link
Member

@keshakaneria Yes it can be but do we need to discuss it with the design team first?

Yes, tagging @nandini45 again as a part of designing project to let us know if this can be done.

@isabelcosta
Copy link
Member

@Rahulm2310 could you fix the merge conflicts? I really like what you did here. Would love to get this on track again!

@isabelcosta isabelcosta added the Status: Changes Requested Changes are required to be done by the PR author. label Oct 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Changes Requested Changes are required to be done by the PR author.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feat: Short the text in events cards and add a new page to display full details
3 participants
@Rahulm2310 @keshakaneria @isabelcosta