Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coding: Develop First Time Issue Section of Contribute Page #160

Closed
wants to merge 2 commits into from
Closed

Coding: Develop First Time Issue Section of Contribute Page #160

wants to merge 2 commits into from

Conversation

rutvi18
Copy link

@rutvi18 rutvi18 commented Oct 29, 2020

Description

Include a summary of the change and relevant motivation/context. List any dependencies that are required for this change.

Fixes #67

Type of Change:

Delete irrelevant options.

  • Code
  • Quality Assurance
  • User Interface
  • Outreach
  • Documentation

Code/Quality Assurance Only

  • Bug fix (non-breaking change which fixes an issue)
  • This change requires a documentation update (software upgrade on readme file)
  • New feature (non-breaking change which adds functionality pre-approved by mentors)

How Has This Been Tested?

If you are working on a design then add a gif to show the responsiveness of your design.
Please follow testing guidelines and share the link of deployed site here.

Checklist:

Delete irrelevant options.

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials
  • I have commented my code or provided relevant documentation, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have attached link of deployed site.
  • Any dependent changes have been merged

Code/Quality Assurance Only

  • My changes generate no new warnings
  • My PR currently breaks something (fix or feature that would cause existing functionality to not work as expected)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been published in downstream modules

@parthsarthiprasad
Copy link
Contributor

parthsarthiprasad commented Oct 30, 2020

@rutvi18 , thanks for this PR, I was following this issue as well, can you please edit the heading to mention the issue that you are working on and linking it with "#67" , that'll help reviewers to find out your PR easily as well.Following the template. Thanks.

@rutvi18 rutvi18 changed the title Contribute rutvi Coding: Develop First Time Issue Section of Contribute Page Oct 30, 2020
@rutvi18
Copy link
Author

rutvi18 commented Oct 30, 2020

@parthsarthiprasad do you mean linking to #67 ?

@Akanksha1212 Akanksha1212 added the Status: Needs Review PR needs an additional review or a maintainer's review. label Oct 31, 2020
Copy link

@prathmeshkhandelwal1 prathmeshkhandelwal1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rutvi18 This PR is giving merge conflict, You should resolve it first. and also plz fill the checklist and types of changes you have done in this PR. You can fill checklist by filling x b/w the brackets [x], And if possible also add ScreenShot of your changes. Feel Free to ask anyone If you stuck anywhere. ;)

"title":"Ways to contibute",
"content":[
{
"par":"bdjbc"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Random text will not be merged, neither Lorem ipsum.

@annabauza annabauza added Status: Changes Requested Changes are required to be done by the PR author. and removed Status: Needs Review PR needs an additional review or a maintainer's review. labels Dec 23, 2020
@rutvi18
Copy link
Author

rutvi18 commented Dec 26, 2020

@tichnas I am closing this PR.

@rutvi18 rutvi18 closed this Dec 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Changes Requested Changes are required to be done by the PR author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Develop First Time Issue Section of Contribute Page
5 participants