Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coding: Develop First Time Issue Section of Contribute Page #245

Closed

Conversation

iamkryptonite
Copy link
Contributor

Description

Added first timer issues Section in Contribute Page. It basically show all the issues that have "first timers only" throughout all the repositories that are present.
Fixes #67 .

Type of Change:

  • Code
  • User Interface

Code/Quality Assurance Only

  • Bug fix (non-breaking change which fixes an issue)
  • This change requires a documentation update (software upgrade on readme file)
  • New feature (non-breaking change which adds functionality pre-approved by mentors)

How Has This Been Tested?

gh-pages Link: here
AnitaB_org_open_source

Checklist:

Delete irrelevant options.

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials
  • I have commented my code or provided relevant documentation, particularly in hard-to-understand areas
  • I have attached link of deployed site.

Code/Quality Assurance Only

  • My changes generate no new warnings

traviscibot and others added 30 commits April 25, 2020 18:33
@iamkryptonite iamkryptonite changed the title Coding: Develop First Time Issue Section of Contribute Page #67 Coding: Develop First Time Issue Section of Contribute Page Feb 28, 2021
@iamkryptonite
Copy link
Contributor Author

iamkryptonite commented Mar 1, 2021

@nandini45 can you please review this. Thanks!

@Rahulm2310
Copy link
Contributor

@nandini45 I think we should not show First Timers only issues from archived projects. Also, only available issues should be visible and not the ones which are assigned. Issues needs to be sorted as well based on time like the latest issues should be shown first.

@nandini45
Copy link
Member

nandini45 commented Mar 3, 2021 via email

@iamkryptonite
Copy link
Contributor Author

Okay cool.

@keshakaneria
Copy link
Member

@nandini45 I think we should not show First Timers only issues from archived projects. Also, only available issues should be visible and not the ones which are assigned. Issues needs to be sorted as well based on time like the latest issues should be shown first.

I agree @Rahulm2310. Also, sorting will help the new comers to invest their time on fresh issues so assigned issues can be ignored while displaying.
@nandini45 Dont worry about the reviewing, we can help you in that 😄 Good luck for the rest of the exams 🤩👍

@nandini45
Copy link
Member

@keshakaneria thanks
i wrapped up with them today. finally
will complete all the work.
thanks for the help

@iamkryptonite
Copy link
Contributor Author

Hey @nandini45, should I go ahead and make the above-mentioned changes?

@nandini45
Copy link
Member

@iamkryptonite have you dpne the changes?
if yes i can ask to Anna to review your work

@iamkryptonite
Copy link
Contributor Author

@nandini45 no I haven't done the changes yet. I'll try to complete it as early as possible.

@iamkryptonite
Copy link
Contributor Author

@nandini45 @annabauza the changes are done and its ready for review.

Copy link
Contributor

@annabauza annabauza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like you adding generated files by build. We don't do that, deployment is automated. Btw it's overlapping when scaling down, see screenshot Screenshot_20210510_220458_com.android.chrome.jpg

@iamkryptonite
Copy link
Contributor Author

Hey! Really sorry for the late reply, my exams were on. Will make the requested changes soon.

@isabelcosta
Copy link
Member

I will close an unassign due to a lack of updates. Thank you @iamkryptonite for your contributions so far :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Develop First Time Issue Section of Contribute Page
7 participants