Update for anki 23.10 #76
Conversation
|
Hi，thank you for the work. Recently I have little time spent on Github ，let alone reviewing PR. I want to recommend you as one of our ankicommunity members or the owner of this repo.would you like to take it? |
|
hi @dobefore ! I have heard you don't have time anymore, thanks for the work up till now. I don't think I'll do much more than minimum keeping the tree up to date with anki but happy to continue with this; I see anki 23.10 beta 1 was released so I'll test this PR with it soonish. |
|
anki 23.10beta1 didn't work with this patch, I had to rebase further -- which is actually probably better as the patch is now based on a release commit and not some random commit in the main branch. With this I've confirmed it works on both an older release (2.1.54) and the 23.10beta1, with 23.10beta1 not working with the current anki-sync-server-rs; so this PR should be good to go. Regarding ankicommunity and/or this repo -- elaborating a bit on my reply from earlier -- I'm maintaining this anki-sync-server-rs' package in nixos, so I'll be happy to keep this repo working as long as all it takes is a simple rebase and minor fixes. With that in mind, I'll be happy to take on maintenance on just this repo (and if so will update the README with a warning as above) What do you think? |
|
Okay, so, sorry to come back on what I just said immediately but someone created a nixos service for anki's built in server (because they read the README here and thought it already wasn't working...), and there really is little point in maintaining both, so we'll likely be dropping this server's service This patch works (I've been using it for a couple of weeks with no issue), so feel free to merge it if you want to take my word for it (or have time to test yourself), and I'll be happy to do minor adjustments like rebasing it on the real 23.10 release commit, but I no longer feel like I should get any rights on this repo. Sorry, and thanks again for this project until now! |
|
I'm happy that the nixos chooses the official anki sync server because this guarantees the consistency and reduces the work of maintaining the sync server. And thanks again for the contribution you have made😁 |
anki 23.10 includes protocol changes (see linked PR, and others) so we need to update the anki base commit and patch. I've aligned the rusqlite dependency to fix rust build, and while I was it aligned a few more where rust would be building an extra version of the lib for anki. Link: ankitects/anki#2647
anki 23.09 will include a protocol change ( ankitects/anki#2647 ) so we need to update the anki base commit and patch.
I've aligned the rusqlite dependency to fix rust build, and while I was it aligned a few more where rust would be building an extra version of the lib for anki.
I was too lazy to build anki master to check if newer client actually syncs with this, but it still works with current anki releases, and the protocol files have been updated so I don't see why it wouldn't work.
I'll test when anki 23.09 is released.