-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GSoC'24] Chore: extension method to get cloze field name #16424
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These all relate to the first field, the second method doesn't return all cloze fields. The names should be changed, or the implementation should be fixed
A little documentation would be useful
Secondly, if the user has multiple filters on the field, I don't believe the second Regex would match this
You should add unit tests for this
This comment was marked as resolved.
This comment was marked as resolved.
AnkiDroid/src/main/java/com/ichi2/anki/utils/CardTemplateJson.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
@criticalAY could you squash this into two commits: one for the typo change, and one for the change Ping me if this isn't done in 24hours and I'll get to it. Don't want to block this |
Done!, made a mistake while rebasing but all good now |
Purpose / Description
Anki allows cloze in only the cloze field which is in
qfmt
undertmpls
here in below screenshotI am creating this extension method so that I can use it in instant note editor to put text and also the bug in NoteEditor i.e.
Text
not consistent in AnkiDroid #16419 can be fixed to check for cloze text in this field along with cloze number >1Checklist
Please, go through these checks before submitting the PR.