Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GSoC'24] Chore: extension method to get cloze field name #16424

Merged
merged 2 commits into from
May 26, 2024

Conversation

criticalAY
Copy link
Contributor

@criticalAY criticalAY commented May 18, 2024

Purpose / Description

Anki allows cloze in only the cloze field which is in qfmt under tmpls here in below screenshot
image

I am creating this extension method so that I can use it in instant note editor to put text and also the bug in NoteEditor i.e.

Checklist

Please, go through these checks before submitting the PR.

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

@criticalAY criticalAY added Needs Review GSoC Pull requests authored by a Google Summer of Code participant [Candidate/Selected], for GSoC mentors labels May 18, 2024
Copy link
Member

@david-allison david-allison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These all relate to the first field, the second method doesn't return all cloze fields. The names should be changed, or the implementation should be fixed

A little documentation would be useful

Secondly, if the user has multiple filters on the field, I don't believe the second Regex would match this

You should add unit tests for this

@david-allison david-allison added Needs Author Reply Waiting for a reply from the original author and removed Needs Review labels May 18, 2024
@criticalAY criticalAY added Needs Review and removed Needs Author Reply Waiting for a reply from the original author labels May 20, 2024
david-allison

This comment was marked as resolved.

@criticalAY criticalAY added the Needs Author Reply Waiting for a reply from the original author label May 20, 2024
@criticalAY

This comment was marked as resolved.

david-allison

This comment was marked as resolved.

@criticalAY criticalAY removed the Needs Author Reply Waiting for a reply from the original author label May 22, 2024
Copy link
Member

@david-allison david-allison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@david-allison david-allison added Needs Second Approval Has one approval, one more approval to merge and removed Needs Review labels May 22, 2024
@ShridharGoel ShridharGoel added Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) and removed Needs Second Approval Has one approval, one more approval to merge labels May 26, 2024
@david-allison david-allison added the Needs reviewer reply Waiting for a reply from another reviewer label May 26, 2024
@david-allison david-allison self-assigned this May 26, 2024
@david-allison
Copy link
Member

@criticalAY could you squash this into two commits: one for the typo change, and one for the change

Ping me if this isn't done in 24hours and I'll get to it. Don't want to block this

@criticalAY
Copy link
Contributor Author

criticalAY commented May 26, 2024

Done!,

made a mistake while rebasing but all good now

@david-allison david-allison added this pull request to the merge queue May 26, 2024
Merged via the queue into ankidroid:main with commit 5ebb74c May 26, 2024
8 checks passed
@github-actions github-actions bot removed the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label May 26, 2024
@github-actions github-actions bot added this to the 2.19 release milestone May 26, 2024
@david-allison david-allison removed the Needs reviewer reply Waiting for a reply from another reviewer label May 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GSoC Pull requests authored by a Google Summer of Code participant [Candidate/Selected], for GSoC mentors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants