-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make permission item fully touchable #16535
base: main
Are you sure you want to change the base?
Conversation
If you are setting the onClick listener to the root layout, then it would be best to remove the redundant code from the switch listener ? I might be wrong but if the layouts can be merged then it can only be set to the parent layout |
Can you add a video? Also, did you test if the switch is unchecked when declined? |
Yes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the whole element is going to be a touch area, it needs some kind of visual feedback, like a Setting does.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@criticalAY I don't understand will you please explain what actually i have to do. |
Tap the switch, nothing happens. It will work only if you tap the layout i.e. the switch/layout should both be tappable and lead to same action |
a09b113
to
4d0a6d7
Compare
This comment was marked as outdated.
This comment was marked as outdated.
I request maintainers to open this PR and review |
Comments need to be resolved |
@criticalAY Comment already resolve kindly check once again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as expected! apologies for the wrong label
Repeating myself:
|
This comment was marked as outdated.
This comment was marked as outdated.
Please reopen this PR |
@BrayanDSO What do you mean by visual feedback? I don't understand. Will you please explain again? |
When you press a setting, there's a gray animation that flows like a wave that acts as feedback. So, something like that. |
The wave is called a 'ripple' in Material Design |
@BrayanDSO @david-allison Already there |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4d0a6d7
to
87c9d50
Compare
Purpose / Description
In PermissionActivity, the permission item is not fully touchable, unlike in the settings.
Approach
setOnClickListener on root layout.
How Has This Been Tested?
WhatsApp.Video.2024-06-07.at.20.38.22_93f151fb.mp4
Checklist
Please, go through these checks before submitting the PR.