Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added multiselect delete in manageNotesType #17091

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jainv4156
Copy link
Contributor

@jainv4156 jainv4156 commented Sep 19, 2024

Added Multiselect delete in manageNoteType

Purpose / Description

Describe the problem or feature and motivation

Fixes

Checklist

Please, go through these checks before submitting the PR.

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner
Screencast.from.2024-09-19.12-33-39.webm

After Changes

  • disabled edit card , rename ,delete
  • pressing back button will disable multiSelect mode rather then nevigating up
Screencast.from.2024-09-22.23-08-54.webm

@brishtibheja
Copy link

I think the current delete option shouldn't be there. It's weird that we have the same functionality twice. Also, it makes me anxious when the delete option (a high-risk option) is very easy to reach.

Perhaps, long-press then delete can become the default, maintainers?

@jainv4156
Copy link
Contributor Author

jainv4156 commented Sep 19, 2024

you got a point. We can disable the delete option while in multiSelect mode or we can completely remove the default delete button

and there is one more problem. When we long press and multiselct mode enables, the other functionalities like add ,rename ,edit are still accessible. so should we disable them too ?

@brishtibheja
Copy link

I'd say yes, remove all but you may want to wait for the maintainers' opinions.

@SanjaySargam
Copy link
Contributor

so should we disable them too ?

Yes, we should disable at least rename, edit, delete

When the user is in multiselect mode and presses the back button, instead of navigating back to the previous screen (DeckPicker screen), the multiselect mode should be exited. The back button press should act as a trigger to clear the current selection and exit the multiselect state, keeping the user on the same screen

@SanjaySargam
Copy link
Contributor

Another issue:
WhatsApp Image 2024-09-22 at 2 57 08 PM
The checkbox is not being displayed for all note types

@jainv4156
Copy link
Contributor Author

Another issue: WhatsApp Image 2024-09-22 at 2 57 08 PM The checkbox is not being displayed for all note types

this is due to adding the new selected note type while in multiselect mode . so should i disable it too or fix this issue

@SanjaySargam
Copy link
Contributor

this is due to adding the new selected note type

That's not the case. To reproduce, have more than 5-10 note types, enable multiselect mode and scroll down

should i disable it too or fix this issue

should fix

@jainv4156
Copy link
Contributor Author

this is due to adding the new selected note type

That's not the case. To reproduce, have more than 5-10 note types, enable multiselect mode and scroll down

should i disable it too or fix this issue

should fix

ok , I'll check and correct it

@SanjaySargam

This comment was marked as resolved.

@jainv4156 jainv4156 force-pushed the my-feature-branch branch 2 times, most recently from 89d3eea to e592419 Compare September 27, 2024 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiselect Note type and delete
3 participants