Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for FSRS simulator (bundles Anki 24.10beta1 - careful if you use this) #17177

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

voczi
Copy link
Contributor

@voczi voczi commented Oct 1, 2024

See title.
We probably have to do some work on the Svelte page so it looks better on mobile. Right now it looks like this:
image
(Legends overflowing is fixed to my knowledge)

Considering I worked a bit with the simulator's Svelte page already, I could maybe also be the one to make it look better on mobile (since Jarrett is on vacation)?

Related PRs:
#17170
ankitects/anki#3257

@mikehardy mikehardy marked this pull request as draft October 1, 2024 17:29
@mikehardy mikehardy changed the title Add support for FSRS simulator (Anki 24.10beta1) Add support for FSRS simulator (bundles Anki 24.10beta1 - careful if you use this) Oct 1, 2024
Copy link
Member

@BrayanDSO BrayanDSO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@BrayanDSO BrayanDSO added Needs Second Approval Has one approval, one more approval to merge Blocked by dependency Currently blocked by some other dependent / related change labels Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocked by dependency Currently blocked by some other dependent / related change Needs Second Approval Has one approval, one more approval to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants