Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Android Studio lint errors in AudioRecordingController.kt #17195

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

benwicks
Copy link
Contributor

@benwicks benwicks commented Oct 3, 2024

Purpose / Description

There were 2 Android Lint errors and 1 warning in AudioRecordingController.kt that are fixed in this PR.

Fixes

Approach

I just picked the first errors after a code inspection and fixed the warning in the file too.

How Has This Been Tested?

No testing is necessary for the changes to parameter ordering.
I added the exception parameter to the one Timber.d call where it was missing. I believe this call will be a no-op for non-debug builds.

Checklist

Please, go through these checks before submitting the PR.

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant