Allow to pass an existing request object in constructor #442
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation always creates the HTTP request from the superglobals:
But this is not always possible (e.g. when using RoadRunner). It's also an issue in combination with other frameworks (see #440).
With this pull request, users can pass their own Symfony HTTP request object in the constructor - if necessary.
Of course one could also extend the
Request
class and do the same. But this would also require extending theServer
class.