Search refactor #127
Merged
Search refactor #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Use async await const / let instead of var Remove code duplicates
Rename options varible const / let instead of var
Add destructurization for data Make vars let and const Fix spaces by template string in title / description
const / let instead of var Some optimizations
use arrow function const / let instead of var
|
Thanks for this amazing PR! I will review it as soon as possible. |
ankitskvmdam
approved these changes
Aug 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Full refactor of search:
2. Prefer
let/const3. Use
async/await4. Make text of search result align center
No new dependencies needed
Maybe you should run build for update
search.min.js, I'm not update it in commitsMotivation: I use this template for https://github.com/OpengramJS/opengram and I think your template deserves better code :)
Type of change
Please mark options that is/are relevant.
I test new base URL calculation with followed URLs and without
base_urloption:https://exmaple.com/- workshttp://exmaple.com/- works/- works/v4/- workshttps://exmaple.com- not works (missing end/)http://exmaple.com- not works (missing end/)/v4- not works (missing end/)